Bug 111581

Summary: Web Inspector: fix closure compiler warnings in the profiler code
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Yury Semikhatsky
Reported 2013-03-06 07:50:33 PST
./Source/WebCore/inspector/compile-front-end.py Source/WebCore/inspector/front-end/FlameChart.js:202: WARNING - Type annotations are not allowed here. Are you missing parentheses? var levelOffsets = /** @type {Array.<!number>} */ [0]; ^ Source/WebCore/inspector/front-end/ProfileLauncherView.js:200: WARNING - Property liveNativeMemoryChart never defined on WebInspector.experimentsSettings if (WebInspector.experimentsSettings.liveNativeMemoryChart.isEnabled()) { ^ Source/WebCore/inspector/front-end/ProfileLauncherView.js:203: WARNING - Property NativeMemoryBarChart never defined on WebInspector this._nativeMemoryLiveChart = new WebInspector.NativeMemoryBarChart(); ^ 0 error(s), 3 warning(s), 81.0% typed Compiling InjectedScriptSource.js... Source/WebCore/inspector/InjectedScriptSourceTmp.js:226: WARNING - Property objectId never defined on InjectedScriptHost var id = InjectedScriptHost.objectId(object); ^ Source/WebCore/inspector/InjectedScriptSourceTmp.js:376: WARNING - Property releaseObjectId never defined on InjectedScriptHost InjectedScriptHost.releaseObjectId(object); ^ 0 error(s), 2 warning(s), 90.3% typed Compiling InjectedScriptCanvasModuleSource.js... 0 error(s), 0 warning(s), 92.4% typed
Attachments
Patch (4.50 KB, patch)
2013-03-06 07:52 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2013-03-06 07:52:17 PST
Created attachment 191750 [details] Patch
WebKit Review Bot
Comment 2 2013-03-06 08:30:20 PST
Comment on attachment 191750 [details] Patch Clearing flags on attachment: 191750 Committed r144932: <http://trac.webkit.org/changeset/144932>
WebKit Review Bot
Comment 3 2013-03-06 08:30:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.