[EFL] Improve warning messages when input value is out of range

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Gyuyoung Kim]

It would be good if we show input value range when user inputs greater or less value.

[Gyuyoung Kim]

Created attachment 191668 [details]
Patch

[Gyuyoung Kim]

Created attachment 191669 [details]
Screenshot

[Chris Dumez]

Comment on attachment 191668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191668&action=review

I seem to remember Benjamin advising to use operator+ for such cases.

> Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:461
> +    builder.append(maximum.utf8().data());

Also using ".utf8().data()" seems odd here.

[EFL EWS Bot]

Comment on attachment 191668 [details]
Patch

Attachment 191668 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17051283

[Gyuyoung Kim]

Created attachment 191683 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #3)
> (From update of attachment 191668 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191668&action=review
> 
> I seem to remember Benjamin advising to use operator+ for such cases.
> 
> > Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:461
> > +    builder.append(maximum.utf8().data());
> 
> Also using ".utf8().data()" seems odd here.

Ok, I modify this patch to be simplified.

[Gyuyoung Kim]

Created attachment 191688 [details]
Patch

[Gyuyoung Kim]

Created attachment 191689 [details]
Patch

[Chris Dumez]

Comment on attachment 191689 [details]
Patch

LGTM.

[Laszlo Gombos]

Comment on attachment 191689 [details]
Patch

r=me.

[WebKit Review Bot]

Comment on attachment 191689 [details]
Patch

Clearing flags on attachment: 191689

Committed r145025: <http://trac.webkit.org/changeset/145025>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.