Bug 111508

Summary: [chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, thakis, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 111504, 111509    
Bug Blocks:    
Attachments:
Description Flags
Patch none

James Robinson
Reported 2013-03-05 18:49:42 PST
[chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp
Attachments
Patch (2.83 KB, patch)
2013-03-05 18:55 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-03-05 18:55:06 PST
Created attachment 191635 [details] Patch
James Robinson
Comment 2 2013-03-05 19:02:25 PST
Comment on attachment 191635 [details] Patch cq- for now, looks like the patch this depends on (to create DumpRenderTree_resources) is having some trouble with the xcode generator.
Dirk Pranke
Comment 3 2013-03-05 19:15:46 PST
(In reply to comment #2) > (From update of attachment 191635 [details]) > cq- for now, looks like the patch this depends on (to create DumpRenderTree_resources) is having some trouble with the xcode generator. Yeah, it looks like putting the resources in a separate target may or may not work correctly w/ xcode. Let's wait and see what nico says about this.
Dirk Pranke
Comment 4 2013-03-06 12:55:35 PST
Comment on attachment 191635 [details] Patch I think this should be fine w/ Tony's approach in bug 11509.
WebKit Review Bot
Comment 5 2013-03-06 13:14:08 PST
Comment on attachment 191635 [details] Patch Clearing flags on attachment: 191635 Committed r144970: <http://trac.webkit.org/changeset/144970>
WebKit Review Bot
Comment 6 2013-03-06 13:14:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.