| Summary: | [chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dpranke, thakis, tony, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 111504, 111509 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
James Robinson
2013-03-05 18:49:42 PST
Created attachment 191635 [details]
Patch
Comment on attachment 191635 [details]
Patch
cq- for now, looks like the patch this depends on (to create DumpRenderTree_resources) is having some trouble with the xcode generator.
(In reply to comment #2) > (From update of attachment 191635 [details]) > cq- for now, looks like the patch this depends on (to create DumpRenderTree_resources) is having some trouble with the xcode generator. Yeah, it looks like putting the resources in a separate target may or may not work correctly w/ xcode. Let's wait and see what nico says about this. Comment on attachment 191635 [details] Patch I think this should be fine w/ Tony's approach in bug 11509. Comment on attachment 191635 [details] Patch Clearing flags on attachment: 191635 Committed r144970: <http://trac.webkit.org/changeset/144970> All reviewed patches have been landed. Closing bug. |