Summary: | [chromium] Remove WebSharedGraphicsContext3D class | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dana Jansens <danakj> | ||||
Component: | New Bugs | Assignee: | Dana Jansens <danakj> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, backer, dglazkov, fishd, jamesr, piman, tkent+wkapi, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dana Jansens
2013-03-05 16:14:15 PST
Created attachment 191594 [details]
Patch
Once https://codereview.chromium.org/12212100/ and https://codereview.chromium.org/12483002/ land, no one will be using this class anymore so we can burn it with fire. Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 191594 [details]
Patch
Out! What chromium rev removed the last dependency on this? Has that rolled into WebKit/chromium/DEPS yet?
The linked changes above haven't landed yet, so no. :) But soon! https://codereview.chromium.org/12212100/ needs a lookover from yourself and piman@ again, now that it's in its more final form with the ContextProvider strategy. Comment on attachment 191594 [details]
Patch
This depends on chromium 186460 and 186342. Current DEPS is now at 186511
Comment on attachment 191594 [details] Patch Clearing flags on attachment: 191594 Committed r145006: <http://trac.webkit.org/changeset/145006> All reviewed patches have been landed. Closing bug. |