Bug 111492

Summary: [chromium] Remove WebSharedGraphicsContext3D class
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, backer, dglazkov, fishd, jamesr, piman, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dana Jansens
Reported 2013-03-05 16:14:15 PST
[chromium] Remove WebSharedGraphicsContext3D class
Attachments
Patch (9.32 KB, patch)
2013-03-05 16:14 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2013-03-05 16:14:58 PST
Created attachment 191594 [details] Patch
Dana Jansens
Comment 2 2013-03-05 16:15:49 PST
Once https://codereview.chromium.org/12212100/ and https://codereview.chromium.org/12483002/ land, no one will be using this class anymore so we can burn it with fire.
WebKit Review Bot
Comment 3 2013-03-05 16:16:55 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 4 2013-03-05 16:17:37 PST
Comment on attachment 191594 [details] Patch Out! What chromium rev removed the last dependency on this? Has that rolled into WebKit/chromium/DEPS yet?
Dana Jansens
Comment 5 2013-03-05 16:19:19 PST
The linked changes above haven't landed yet, so no. :) But soon! https://codereview.chromium.org/12212100/ needs a lookover from yourself and piman@ again, now that it's in its more final form with the ContextProvider strategy.
Dana Jansens
Comment 6 2013-03-06 16:19:28 PST
Comment on attachment 191594 [details] Patch This depends on chromium 186460 and 186342. Current DEPS is now at 186511
WebKit Review Bot
Comment 7 2013-03-06 16:34:41 PST
Comment on attachment 191594 [details] Patch Clearing flags on attachment: 191594 Committed r145006: <http://trac.webkit.org/changeset/145006>
WebKit Review Bot
Comment 8 2013-03-06 16:34:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.