Bug 111492 - [chromium] Remove WebSharedGraphicsContext3D class
Summary: [chromium] Remove WebSharedGraphicsContext3D class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-05 16:14 PST by Dana Jansens
Modified: 2013-03-06 16:34 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.32 KB, patch)
2013-03-05 16:14 PST, Dana Jansens 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2013-03-05 16:14:15 PST 
[chromium] Remove WebSharedGraphicsContext3D class
Comment 1 Dana Jansens 2013-03-05 16:14:58 PST 
Created attachment 191594 [details]
Patch
Comment 2 Dana Jansens 2013-03-05 16:15:49 PST 
Once https://codereview.chromium.org/12212100/ and https://codereview.chromium.org/12483002/ land, no one will be using this class anymore so we can burn it with fire.
Comment 3 WebKit Review Bot 2013-03-05 16:16:55 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 James Robinson 2013-03-05 16:17:37 PST 
Comment on attachment 191594 [details]
Patch

Out!  What chromium rev removed the last dependency on this?  Has that rolled into WebKit/chromium/DEPS yet?
Comment 5 Dana Jansens 2013-03-05 16:19:19 PST 
The linked changes above haven't landed yet, so no. :) But soon!

https://codereview.chromium.org/12212100/ needs a lookover from yourself and piman@ again, now that it's in its more final form with the ContextProvider strategy.
Comment 6 Dana Jansens 2013-03-06 16:19:28 PST 
Comment on attachment 191594 [details]
Patch

This depends on chromium 186460 and 186342. Current DEPS is now at 186511
Comment 7 WebKit Review Bot 2013-03-06 16:34:41 PST 
Comment on attachment 191594 [details]
Patch

Clearing flags on attachment: 191594

Committed r145006: <http://trac.webkit.org/changeset/145006>
Comment 8 WebKit Review Bot 2013-03-06 16:34:45 PST 
All reviewed patches have been landed.  Closing bug.