Bug 111486

Summary: Add V8Document.h include when the V8 code generator creates a toV8(Document*) call.
Product: WebKit Reporter: Aaron Colwell <acolwell>
Component: New BugsAssignee: Aaron Colwell <acolwell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix run-bindings-tests expectations none

Aaron Colwell
Reported 2013-03-05 14:45:04 PST
Add V8Document.h include when the V8 code generator creates a toV8(Document*) call.
Attachments
Patch (1.41 KB, patch)
2013-03-05 14:46 PST, Aaron Colwell 		no flags
DetailsFormatted DiffDiff
Fix run-bindings-tests expectations (2.05 KB, patch)
2013-03-05 15:33 PST, Aaron Colwell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aaron Colwell
Comment 1 2013-03-05 14:46:00 PST
Created attachment 191570 [details] Patch
Aaron Colwell
Comment 2 2013-03-05 14:54:43 PST
It's not obvious from the patch context, but the line below the "Document* document = currentDocument(BindingState::instance());" line uses the Document* version of toV8() declared in V8Document.h. While tracking down a crash that led me to move the ActiveDOMObject annotation from HTMLAudioElement.idl to HTMLMediaElement.idl, I discovered a build breaker caused by this missing include.
Adam Barth
Comment 3 2013-03-05 15:19:37 PST
Please run-bindings-tests before landing.
Aaron Colwell
Comment 4 2013-03-05 15:33:03 PST
Created attachment 191585 [details] Fix run-bindings-tests expectations
WebKit Review Bot
Comment 5 2013-03-05 16:21:46 PST
Comment on attachment 191585 [details] Fix run-bindings-tests expectations Clearing flags on attachment: 191585 Committed r144846: <http://trac.webkit.org/changeset/144846>
WebKit Review Bot
Comment 6 2013-03-05 16:21:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.