Bug 111486

Summary:

Add V8Document.h include when the V8 code generator creates a toV8(Document*) call.

Product:

WebKit

Reporter:

Aaron Colwell <acolwell>

Component:

New Bugs

Assignee:

Aaron Colwell <acolwell>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, haraken, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Fix run-bindings-tests expectations	none

Description Aaron Colwell 2013-03-05 14:45:04 PST

Add V8Document.h include when the V8 code generator creates a toV8(Document*) call.

Comment 1 Aaron Colwell 2013-03-05 14:46:00 PST

Created attachment 191570 [details]
Patch

Comment 2 Aaron Colwell 2013-03-05 14:54:43 PST

It's not obvious from the patch context, but the line below the "Document* document = currentDocument(BindingState::instance());" line uses the Document* version of toV8() declared in V8Document.h. 

While tracking down a crash that led me to move the ActiveDOMObject annotation from HTMLAudioElement.idl to HTMLMediaElement.idl, I discovered a build breaker caused by this missing include.

Comment 3 Adam Barth 2013-03-05 15:19:37 PST

Please run-bindings-tests before landing.

Comment 4 Aaron Colwell 2013-03-05 15:33:03 PST

Created attachment 191585 [details]
Fix run-bindings-tests expectations

Comment 5 WebKit Review Bot 2013-03-05 16:21:46 PST

Comment on attachment 191585 [details]
Fix run-bindings-tests expectations

Clearing flags on attachment: 191585

Committed r144846: <http://trac.webkit.org/changeset/144846>

Comment 6 WebKit Review Bot 2013-03-05 16:21:49 PST

All reviewed patches have been landed.  Closing bug.