| Summary: | Dashboard cleanup: move string utilities into their own namespace. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julie Parent <jparent> | ||||||
| Component: | Tools / Tests | Assignee: | Julie Parent <jparent> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dpranke, ojan, tony, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Julie Parent
2013-03-05 14:42:05 PST
Created attachment 191572 [details]
Patch
Comment on attachment 191572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191572&action=review > Tools/TestResultServer/static-dashboards/string.js:30 > +var stringUtil = stringUtil || {}; How about s/stringUtil/string? Comment on attachment 191572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191572&action=review >> Tools/TestResultServer/static-dashboards/string.js:30 >> +var stringUtil = stringUtil || {}; > > How about s/stringUtil/string? I originally used string, but I thought that was confusing because there is the built-in String. Util is a useless word. I don't think there's much threat of people confusing string.contains with String.contains. I'd rather have something like base.string than stringUtil. My preference is still for just plain string though. Created attachment 191584 [details]
Patch
(In reply to comment #4) > Util is a useless word. I don't think there's much threat of people confusing string.contains with String.contains. > > I'd rather have something like base.string than stringUtil. My preference is still for just plain string though. Changed to string. Comment on attachment 191584 [details] Patch Clearing flags on attachment: 191584 Committed r144845: <http://trac.webkit.org/changeset/144845> All reviewed patches have been landed. Closing bug. |