Bug 111485

Summary: Dashboard cleanup: move string utilities into their own namespace.
Product: WebKit Reporter: Julie Parent <jparent>
Component: Tools / TestsAssignee: Julie Parent <jparent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Julie Parent
Reported 2013-03-05 14:42:05 PST
Dashboard cleanup: move string utilities into their own namespace.
Attachments
Patch (24.30 KB, patch)
2013-03-05 14:49 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch (24.05 KB, patch)
2013-03-05 15:32 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2013-03-05 14:49:55 PST
Created attachment 191572 [details] Patch
Ojan Vafai
Comment 2 2013-03-05 15:10:50 PST
Comment on attachment 191572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191572&action=review > Tools/TestResultServer/static-dashboards/string.js:30 > +var stringUtil = stringUtil || {}; How about s/stringUtil/string?
Julie Parent
Comment 3 2013-03-05 15:13:51 PST
Comment on attachment 191572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191572&action=review >> Tools/TestResultServer/static-dashboards/string.js:30 >> +var stringUtil = stringUtil || {}; > > How about s/stringUtil/string? I originally used string, but I thought that was confusing because there is the built-in String.
Ojan Vafai
Comment 4 2013-03-05 15:20:41 PST
Util is a useless word. I don't think there's much threat of people confusing string.contains with String.contains. I'd rather have something like base.string than stringUtil. My preference is still for just plain string though.
Julie Parent
Comment 5 2013-03-05 15:32:57 PST
Created attachment 191584 [details] Patch
Julie Parent
Comment 6 2013-03-05 15:33:31 PST
(In reply to comment #4) > Util is a useless word. I don't think there's much threat of people confusing string.contains with String.contains. > > I'd rather have something like base.string than stringUtil. My preference is still for just plain string though. Changed to string.
WebKit Review Bot
Comment 7 2013-03-05 16:20:55 PST
Comment on attachment 191584 [details] Patch Clearing flags on attachment: 191584 Committed r144845: <http://trac.webkit.org/changeset/144845>
WebKit Review Bot
Comment 8 2013-03-05 16:20:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.