Bug 111448

Summary:

[GTK][WK2] Implement WebInspector::localizedStringsURL() to return the file URL of localizedStrings.js

Product:

WebKit

Reporter:

Sudarsana Nagineni (babu) <naginenis>

Component:

WebKitGTK

Assignee:

Sudarsana Nagineni (babu) <naginenis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, cgarcia, gustavo, mrobinson, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sudarsana Nagineni (babu) 2013-03-05 09:07:25 PST

Implement WebInspector::localizedStringsURL() method, so that it will prevent printing warnings about "Localized string not found" in the console when the Web Inspector opened.

Comment 1 Sudarsana Nagineni (babu) 2013-03-06 05:41:37 PST

Created attachment 191729 [details]
Patch

Comment 2 Martin Robinson 2013-03-06 07:35:48 PST

I wonder if this should be included in the GResources bundle. What do you think Carlos?

Comment 3 Carlos Garcia Campos 2013-03-06 07:54:58 PST

We don't have GResource bundle yet, no? my plan was to include all the inspector resources as a GResource in the library itself, to avoid the problems of resources not found when not installed and to avoid a lot of disk io.

Comment 4 Martin Robinson 2013-03-06 08:05:25 PST

(In reply to comment #3)
> We don't have GResource bundle yet, no? my plan was to include all the inspector resources as a GResource in the library itself, to avoid the problems of resources not found when not installed and to avoid a lot of disk io.

Sorry. I thought inspector resources were already stored as GResource data in the library itself. If not, this patch seems fine to me.

Comment 5 Carlos Garcia Campos 2013-03-06 08:11:42 PST

(In reply to comment #4)
> (In reply to comment #3)
> > We don't have GResource bundle yet, no? my plan was to include all the inspector resources as a GResource in the library itself, to avoid the problems of resources not found when not installed and to avoid a lot of disk io.
> 
> Sorry. I thought inspector resources were already stored as GResource data in the library itself. If not, this patch seems fine to me.

For now it's only a plan, the main problem is that we would need to bump glib (and probably libsoup) requirements, or do both, install the resources and compile them as a gresource, falling back to the installed files if the resources are not present in the library.

Comment 6 Martin Robinson 2013-03-06 08:17:33 PST

Maybe a WebKit2 owner could put the final stamp on this one?

Comment 7 Sudarsana Nagineni (babu) 2013-03-06 14:12:34 PST

Comment on attachment 191729 [details]
Patch

Thanks for reviewing.

Comment 8 WebKit Review Bot 2013-03-06 14:28:56 PST

Comment on attachment 191729 [details]
Patch

Clearing flags on attachment: 191729

Committed r144982: <http://trac.webkit.org/changeset/144982>

Comment 9 WebKit Review Bot 2013-03-06 14:28:59 PST

All reviewed patches have been landed.  Closing bug.