Bug 111442

Summary: Web Inspector: Flame Chart. Provide node context info in a popover when mouse hovers over a flame chart item
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Ilya Tikhonovsky
Reported 2013-03-05 08:04:22 PST
EOM
Attachments
Patch (5.38 KB, patch)
2013-03-05 08:07 PST, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2013-03-05 08:07:03 PST
Created attachment 191499 [details] Patch
Yury Semikhatsky
Comment 2 2013-03-05 08:24:32 PST
Comment on attachment 191499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191499&action=review Please attach a screenshot. > Source/WebCore/ChangeLog:8 > + FlameChart creates a fake anchor element and moves it to the right position. Can you rephrase this or add more context? > Source/WebCore/inspector/front-end/FlameChart.js:93 > + if (typeof node === 'undefined' && !this._highlightedNode) Please use " instead of ' > Source/WebCore/inspector/front-end/FlameChart.js:120 > + style.height = this._yScaleFactor + "px"; Consider renaming _yScaleFactor to _barHeight
Note You need to log in before you can comment on or make changes to this bug.