Summary: | Web Inspector: move PopoverContentHelper from TimelinePresentationModel.js to Popover.js | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2013-03-05 06:18:59 PST
Created attachment 191483 [details]
Patch
Comment on attachment 191483 [details]
Patch
LGTM
Comment on attachment 191483 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191483&action=review > Source/WebCore/inspector/front-end/Popover.js:374 > +WebInspector.PopupContentHelper = function(title) Consider renaming to PopoverTableHelper ? > Source/WebCore/inspector/front-end/Popover.js:430 > + appendStackTrace: function(title, stackTrace, callFrameLinkifier) Now Popover.js depends on the stack trace, can we avoid this? Committed r144759: <http://trac.webkit.org/changeset/144759> |