Bug 111431

Summary:

Web Inspector: move PopoverContentHelper from TimelinePresentationModel.js to Popover.js

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Ilya Tikhonovsky

Reported 2013-03-05 06:18:59 PST

I'd like to reuse PopoverContentHelper in FlameChart.

Attachments
Patch (26.72 KB, patch) 2013-03-05 06:31 PST, Ilya Tikhonovsky	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2013-03-05 06:31:33 PST

Created attachment 191483 [details] Patch

Andrey Kosyakov

Comment 2 2013-03-05 06:32:51 PST

Comment on attachment 191483 [details] Patch LGTM

Yury Semikhatsky

Comment 3 2013-03-05 06:43:31 PST

Comment on attachment 191483 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191483&action=review > Source/WebCore/inspector/front-end/Popover.js:374 > +WebInspector.PopupContentHelper = function(title) Consider renaming to PopoverTableHelper ? > Source/WebCore/inspector/front-end/Popover.js:430 > + appendStackTrace: function(title, stackTrace, callFrameLinkifier) Now Popover.js depends on the stack trace, can we avoid this?

Ilya Tikhonovsky

Comment 4 2013-03-05 07:31:25 PST

Committed r144759: <http://trac.webkit.org/changeset/144759>

Note You need to log in before you can comment on or make changes to this bug.