Summary: | PDFPlugin: Make scrolling between pages in non-continuous modes work | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
Component: | Assignee: | Tim Horton <thorton> | |||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tim Horton
2013-03-05 01:38:06 PST
Created attachment 191441 [details]
patch that needs some love
Created attachment 192410 [details]
patch
Attachment 192410 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFLayerControllerDetails.h', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm']" exit_code: 1
Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:116: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 192465 [details]
stylebot
Comment on attachment 192465 [details] stylebot View in context: https://bugs.webkit.org/attachment.cgi?id=192465&action=review > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:90 > +static int defaultScrollMagnitudeThresholdForPageFlip = 20; s/static/const/? > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:1010 > + [CATransaction begin]; I don't know why this is needed, taking on trust. |