Bug 111399

Summary:

Inline min/maxInstrinsicLogicalWidth functions

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eae, eric, esprehn+autocc, leviw, ojan.autocc, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	tony: review+

Description Ojan Vafai 2013-03-04 20:02:30 PST

Inline min/maxInstrinsicLogicalWidth functions

Comment 1 Ojan Vafai 2013-03-05 12:03:42 PST

Created attachment 191530 [details]
Patch

Comment 2 Tony Chang 2013-03-05 12:44:06 PST

Comment on attachment 191530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191530&action=review

> Source/WebCore/rendering/RenderBox.cpp:2116
> +        RenderView* renderView = view();
> +        LayoutUnit marginStart = minimumValueForLength(style()->marginStart(), availableLogicalWidth, renderView);
> +        LayoutUnit marginEnd = minimumValueForLength(style()->marginEnd(), availableLogicalWidth, renderView);

Maybe you should pass in 2 additional args to fillAvailableMeasure that will return marginStart and marginEnd by reference?  Maybe this should just be 2 separate methods.

Comment 3 Ojan Vafai 2013-03-05 14:06:55 PST

Committed r144816: <http://trac.webkit.org/changeset/144816>