Bug 111399

Summary: Inline min/maxInstrinsicLogicalWidth functions
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, esprehn+autocc, leviw, ojan.autocc, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Ojan Vafai
Reported 2013-03-04 20:02:30 PST
Inline min/maxInstrinsicLogicalWidth functions
Attachments
Patch (7.22 KB, patch)
2013-03-05 12:03 PST, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2013-03-05 12:03:42 PST
Created attachment 191530 [details] Patch
Tony Chang
Comment 2 2013-03-05 12:44:06 PST
Comment on attachment 191530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191530&action=review > Source/WebCore/rendering/RenderBox.cpp:2116 > + RenderView* renderView = view(); > + LayoutUnit marginStart = minimumValueForLength(style()->marginStart(), availableLogicalWidth, renderView); > + LayoutUnit marginEnd = minimumValueForLength(style()->marginEnd(), availableLogicalWidth, renderView); Maybe you should pass in 2 additional args to fillAvailableMeasure that will return marginStart and marginEnd by reference? Maybe this should just be 2 separate methods.
Ojan Vafai
Comment 3 2013-03-05 14:06:55 PST
Committed r144816: <http://trac.webkit.org/changeset/144816>
Note You need to log in before you can comment on or make changes to this bug.