Bug 111381

Summary:

Upgrade ANGLE to r1987

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

WebGL

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, dino, d-r, mifenton, mrobinson, noam, rwlbuis, tonikitoo, webkit-ews, webkit.review.bot, zmo

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Fixed Qt build failure	none

Kenneth Russell

Reported 2013-03-04 16:35:37 PST

ANGLE needs to be upgraded to r1987 to pick up proper conditional support for highp in fragment shaders on OpenGL ES 2.0 platforms. The ports need to be updated to properly query for support and enable it.

Attachments
Patch (19.45 KB, patch) 2013-03-04 16:38 PST, Kenneth Russell	no flags	Details Formatted Diff Diff
Fixed Qt build failure (19.43 KB, patch) 2013-03-04 17:49 PST, Kenneth Russell	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kenneth Russell

Comment 1 2013-03-04 16:38:43 PST

Created attachment 191347 [details] Patch

WebKit Review Bot

Comment 2 2013-03-04 16:41:29 PST

Attachment 191347 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h', u'Source/ThirdParty/ANGLE/src/common/version.h', u'Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h', u'Source/ThirdParty/ANGLE/src/compiler/ShHandle.h', u'Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp', u'Source/ThirdParty/ANGLE/src/compiler/UnfoldShortCircuit.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang.l', u'Source/ThirdParty/ANGLE/src/compiler/glslang.y', u'Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp', u'Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp', u'Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp', u'Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm', u'Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp']" exit_code: 1 Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h:61: One space before end of line comments [whitespace/comments] [5] Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp:761: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2013-03-04 17:19:53 PST

Comment on attachment 191347 [details] Patch Attachment 191347 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16903196

Early Warning System Bot

Comment 4 2013-03-04 17:39:57 PST

Comment on attachment 191347 [details] Patch Attachment 191347 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16923049

Kenneth Russell

Comment 5 2013-03-04 17:49:47 PST

Created attachment 191366 [details] Fixed Qt build failure

WebKit Review Bot

Comment 6 2013-03-04 17:52:06 PST

Attachment 191366 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h', u'Source/ThirdParty/ANGLE/src/common/version.h', u'Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h', u'Source/ThirdParty/ANGLE/src/compiler/ShHandle.h', u'Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp', u'Source/ThirdParty/ANGLE/src/compiler/UnfoldShortCircuit.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang.l', u'Source/ThirdParty/ANGLE/src/compiler/glslang.y', u'Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp', u'Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp', u'Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp', u'Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm', u'Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp']" exit_code: 1 Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h:61: One space before end of line comments [whitespace/comments] [5] Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp:761: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 7 2013-03-05 15:52:08 PST

Comment on attachment 191366 [details] Fixed Qt build failure Clearing flags on attachment: 191366 Committed r144833: <http://trac.webkit.org/changeset/144833>

WebKit Review Bot

Comment 8 2013-03-05 15:52:12 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.