Bug 111357

Summary: Web Inspector: Cmd+L (Go-to-Line) masks Go to location bar action
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Pavel Feldman
Reported 2013-03-04 12:44:14 PST
We should only consume Cmd+L on the source files.
Attachments
Patch (6.88 KB, patch)
2013-03-05 01:07 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-05 01:00:39 PST
Go-to-Line dialog is installed in 3 panels. But in most cases it can't be activated because no line-based views are shown. I propose to turn shortcut "handlers" to be handlers. This means that they should return true IFF they actually performed some action.
Eugene Klyuchnikov
Comment 2 2013-03-05 01:07:08 PST
Created attachment 191427 [details] Patch
WebKit Review Bot
Comment 3 2013-03-07 00:11:03 PST
Comment on attachment 191427 [details] Patch Clearing flags on attachment: 191427 Committed r145045: <http://trac.webkit.org/changeset/145045>
WebKit Review Bot
Comment 4 2013-03-07 00:11:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.