Bug 111311

Summary: MediaStream API: Add the getStreamById method on RTCPeerConnection
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, esprehn+autocc, feature-media-reviews, fishd, hta, jamesr, jer.noble, jochen, ojan.autocc, tkent+wkapi, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459, 111410    
Attachments:
Description Flags
Patch
abarth: review+
Patch for landing
none
Patch for landing none

Tommy Widenflycht
Reported 2013-03-04 06:26:46 PST
MediaStream API: Add the getStreamById method on RTCPeerConnection
Attachments
Patch (14.18 KB, patch)
2013-03-04 06:34 PST, Tommy Widenflycht 		abarth: review+
DetailsFormatted DiffDiff
Patch for landing (14.18 KB, patch)
2013-03-05 01:08 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.02 KB, patch)
2013-03-05 01:37 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2013-03-04 06:34:15 PST
Created attachment 191224 [details] Patch
Tommy Widenflycht
Comment 2 2013-03-04 06:37:16 PST
Also took the opportunity to fix the readyState handling of MediaStreamSource. It is allowed to set the readystate to ended more than once.
WebKit Review Bot
Comment 3 2013-03-04 06:38:13 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 4 2013-03-04 12:49:47 PST
Comment on attachment 191224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191224&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:434 > +MediaStream* RTCPeerConnection::getStreamById(String streamId) String -> const String& > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:438 > + return (*iter).get(); (*iter).get() -> iter->get() ?
Tommy Widenflycht
Comment 5 2013-03-05 01:08:29 PST
Created attachment 191428 [details] Patch for landing
Tommy Widenflycht
Comment 6 2013-03-05 01:09:12 PST
Comment on attachment 191224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191224&action=review >> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:434 >> +MediaStream* RTCPeerConnection::getStreamById(String streamId) > > String -> const String& Fixed. >> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:438 >> + return (*iter).get(); > > (*iter).get() -> iter->get() ? Done.
Tommy Widenflycht
Comment 7 2013-03-05 01:37:35 PST
Created attachment 191437 [details] Patch for landing
Tommy Widenflycht
Comment 8 2013-03-05 01:38:49 PST
Removed a TestExpectations exception for a test in the latest patch because this code fixes the issue.
WebKit Review Bot
Comment 9 2013-03-05 03:36:40 PST
Comment on attachment 191437 [details] Patch for landing Clearing flags on attachment: 191437 Committed r144748: <http://trac.webkit.org/changeset/144748>
Note You need to log in before you can comment on or make changes to this bug.