Bug 111297

Summary: [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, buildbot, cmarcelo, dglazkov, eric.carlson, esprehn+autocc, feature-media-reviews, gyuyoung.kim, jer.noble, macpherson, menard, ojan.autocc, peter+ews, rakuco, rego+ews, rniwa, sam, vestbo, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Benjamin Poulain
Reported 2013-03-04 02:28:08 PST
[Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
Attachments
Patch (20.19 KB, patch)
2013-03-04 02:37 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (20.21 KB, patch)
2013-03-05 01:04 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (42.82 KB, patch)
2013-03-05 01:37 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (42.59 KB, patch)
2013-03-05 11:24 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (58.15 KB, patch)
2013-03-06 23:15 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-03-04 02:37:42 PST
Created attachment 191183 [details] Patch
Early Warning System Bot
Comment 2 2013-03-04 02:52:49 PST
Comment on attachment 191183 [details] Patch Attachment 191183 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16908530
Early Warning System Bot
Comment 3 2013-03-04 02:55:11 PST
Comment on attachment 191183 [details] Patch Attachment 191183 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16918067
WebKit Review Bot
Comment 4 2013-03-04 03:05:18 PST
Comment on attachment 191183 [details] Patch Attachment 191183 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16899797
EFL EWS Bot
Comment 5 2013-03-04 03:12:25 PST
Comment on attachment 191183 [details] Patch Attachment 191183 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16913338
WebKit Review Bot
Comment 6 2013-03-04 03:31:44 PST
Comment on attachment 191183 [details] Patch Attachment 191183 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16911452
Peter Beverloo (cr-android ews)
Comment 7 2013-03-04 16:55:32 PST
Comment on attachment 191183 [details] Patch Attachment 191183 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/16851538
Benjamin Poulain
Comment 8 2013-03-05 01:04:07 PST
Created attachment 191426 [details] Patch
Early Warning System Bot
Comment 9 2013-03-05 01:19:29 PST
Comment on attachment 191426 [details] Patch Attachment 191426 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17025056
Early Warning System Bot
Comment 10 2013-03-05 01:32:04 PST
Comment on attachment 191426 [details] Patch Attachment 191426 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17051020
Benjamin Poulain
Comment 11 2013-03-05 01:37:52 PST
Created attachment 191438 [details] Patch
Benjamin Poulain
Comment 12 2013-03-05 01:51:54 PST
Damn it, build systems sucks :(
Benjamin Poulain
Comment 13 2013-03-05 11:24:40 PST
Created attachment 191521 [details] Patch
Build Bot
Comment 14 2013-03-05 13:07:33 PST
Comment on attachment 191521 [details] Patch Attachment 191521 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17077001
Build Bot
Comment 15 2013-03-06 01:57:19 PST
Comment on attachment 191521 [details] Patch Attachment 191521 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17058023
Build Bot
Comment 16 2013-03-06 02:57:26 PST
Comment on attachment 191521 [details] Patch Attachment 191521 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17042233
Benjamin Poulain
Comment 17 2013-03-06 23:15:25 PST
Created attachment 191929 [details] Patch
Benjamin Poulain
Comment 18 2013-03-08 12:42:06 PST
Comment on attachment 191929 [details] Patch Clearing flags on attachment: 191929 Committed r145255: <http://trac.webkit.org/changeset/145255>
Benjamin Poulain
Comment 19 2013-03-08 12:42:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.