Bug 111294

Summary: Cleanup: Move HitTestLocation and HitTestResult into separate files.
Product: WebKit Reporter: Mike West <mkwst>
Component: WebCore Misc.Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, buildbot, dglazkov, eric, esprehn+autocc, gyuyoung.kim, ojan.autocc, ossy, rakuco, rego+ews, rniwa, WebkitBugTracker, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Mike West
Reported 2013-03-04 01:36:50 PST
I noticed the FIXME while trying to understand some related code, so I might as well just take care of it; there's no good reason to keep HitTestLocation and HitTestResult in the same file.
Attachments
Patch (30.25 KB, patch)
2013-03-04 01:58 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Patch (20.12 KB, patch)
2013-03-04 05:42 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Patch (30.62 KB, patch)
2013-03-04 06:14 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.64 KB, patch)
2013-03-05 01:36 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2013-03-04 01:58:19 PST
Created attachment 191177 [details] Patch
Allan Sandfeld Jensen
Comment 2 2013-03-04 02:02:38 PST
Comment on attachment 191177 [details] Patch LGTM, pending on the builds bots clearing it.
Mike West
Comment 3 2013-03-04 02:04:20 PST
That was a shockingly fast review. Thanks. :)
Early Warning System Bot
Comment 4 2013-03-04 02:07:59 PST
Comment on attachment 191177 [details] Patch Attachment 191177 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16910526
Early Warning System Bot
Comment 5 2013-03-04 02:10:47 PST
Comment on attachment 191177 [details] Patch Attachment 191177 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16917158
Mike West
Comment 6 2013-03-04 05:42:50 PST
Created attachment 191212 [details] Patch
Mike West
Comment 7 2013-03-04 05:44:03 PST
(In reply to comment #6) > Created an attachment (id=191212) [details] > Patch Ossy pointed me in the right direction regarding Qt (thanks!). If it passes the bots this time, I'll CQ it.
WebKit Review Bot
Comment 8 2013-03-04 05:51:47 PST
Comment on attachment 191212 [details] Patch Attachment 191212 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16917248
Build Bot
Comment 9 2013-03-04 05:53:44 PST
Comment on attachment 191212 [details] Patch Attachment 191212 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16917246
Early Warning System Bot
Comment 10 2013-03-04 05:57:12 PST
Comment on attachment 191212 [details] Patch Attachment 191212 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16912517
EFL EWS Bot
Comment 11 2013-03-04 05:58:39 PST
Comment on attachment 191212 [details] Patch Attachment 191212 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16916284
Early Warning System Bot
Comment 12 2013-03-04 06:01:10 PST
Comment on attachment 191212 [details] Patch Attachment 191212 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16898871
Mike West
Comment 13 2013-03-04 06:04:07 PST
(In reply to comment #12) > (From update of attachment 191212 [details]) > Attachment 191212 [details] did not pass qt-wk2-ews (qt): > Output: http://webkit-commit-queue.appspot.com/results/16898871 *sigh* Today is not my day. I'll upload a new patch in a moment. One that actually includes the files I'm adding. :(
Mike West
Comment 14 2013-03-04 06:14:46 PST
Created attachment 191220 [details] Patch
Mike West
Comment 15 2013-03-05 00:36:58 PST
Comment on attachment 191220 [details] Patch Bots are happy. CQing.
WebKit Review Bot
Comment 16 2013-03-05 00:45:38 PST
Comment on attachment 191220 [details] Patch Rejecting attachment 191220 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 191220, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file Source/WebCore/rendering/HitTestLocation.cpp patching file Source/WebCore/rendering/HitTestLocation.h patching file Source/WebCore/rendering/HitTestResult.cpp patching file Source/WebCore/rendering/HitTestResult.h patching file Source/WebCore/rendering/RenderBlock.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://webkit-commit-queue.appspot.com/results/17050011
Mike West
Comment 17 2013-03-05 01:36:20 PST
Created attachment 191436 [details] Patch for landing
WebKit Review Bot
Comment 18 2013-03-05 02:07:43 PST
Comment on attachment 191436 [details] Patch for landing Clearing flags on attachment: 191436 Committed r144743: <http://trac.webkit.org/changeset/144743>
WebKit Review Bot
Comment 19 2013-03-05 02:07:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.