Bug 111289

Summary: Add a build flag for FontLoader
Product: WebKit Reporter: Kunihiko Sakamoto <ksakamoto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, benjamin, cmarcelo, dbates, eric, gyuyoung.kim, ojan.autocc, rakuco, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98395    
Attachments:
Description Flags
Patch
none
Patch2, renamed it to ENABLE_FONT_LOAD_EVENTS
none
Patch3, fixed flag descriptions none

Kunihiko Sakamoto
Reported 2013-03-04 00:22:37 PST
Add a build flag for FontLoader support (disabled by default).
Attachments
Patch (44.03 KB, patch)
2013-03-04 00:36 PST, Kunihiko Sakamoto 		no flags
DetailsFormatted DiffDiff
Patch2, renamed it to ENABLE_FONT_LOAD_EVENTS (44.18 KB, patch)
2013-03-04 01:26 PST, Kunihiko Sakamoto 		no flags
DetailsFormatted DiffDiff
Patch3, fixed flag descriptions (44.20 KB, patch)
2013-03-04 02:08 PST, Kunihiko Sakamoto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kunihiko Sakamoto
Comment 1 2013-03-04 00:36:20 PST
Created attachment 191166 [details] Patch
Benjamin Poulain
Comment 2 2013-03-04 00:43:47 PST
What is Font Loader? The name is a little generic, we already load custom fonts :)
Kunihiko Sakamoto
Comment 3 2013-03-04 00:53:35 PST
We are implementing the font load events spec'd in the CSS Font Load Events Module Level 3 [1]. FontLoader is the name of the interface which provides ways to detect font loading. Please see the tracking bug [2] for details. [1] http://dev.w3.org/csswg/css-font-load-events-3/ [2] https://bugs.webkit.org/show_bug.cgi?id=98395
Benjamin Poulain
Comment 4 2013-03-04 01:00:20 PST
(In reply to comment #3) > We are implementing the font load events spec'd in the CSS Font Load Events Module Level 3 [1]. > FontLoader is the name of the interface which provides ways to detect font loading. > Please see the tracking bug [2] for details. > > [1] http://dev.w3.org/csswg/css-font-load-events-3/ > [2] https://bugs.webkit.org/show_bug.cgi?id=98395 Then, in my opinion, the flag should be named ENABLE_FONT_LOAD_EVENTS. This spec looks like a nice idea but...you should start by announcing it on webkit-dev. See http://trac.webkit.org/wiki/AddingFeatures
Kunihiko Sakamoto
Comment 5 2013-03-04 01:05:17 PST
https://lists.webkit.org/pipermail/webkit-dev/2013-January/023541.html was the announcement :)
Benjamin Poulain
Comment 6 2013-03-04 01:07:00 PST
(In reply to comment #5) > https://lists.webkit.org/pipermail/webkit-dev/2013-January/023541.html was the announcement :) Oops, sorry. I completely forgot about that. (in my defense, that was a month ago :) )
Kunihiko Sakamoto
Comment 7 2013-03-04 01:26:24 PST
Created attachment 191172 [details] Patch2, renamed it to ENABLE_FONT_LOAD_EVENTS
Benjamin Poulain
Comment 8 2013-03-04 01:59:19 PST
Comment on attachment 191172 [details] Patch2, renamed it to ENABLE_FONT_LOAD_EVENTS View in context: https://bugs.webkit.org/attachment.cgi?id=191172&action=review > Source/cmake/WebKitFeatures.cmake:53 > + WEBKIT_OPTION_DEFINE(ENABLE_FONT_LOAD_EVENTS "Toggle FontLoader support" OFF) "Toggle Font Load Events support"? > Tools/Scripts/webkitperl/FeatureList.pm:262 > + { option => "font-loader", desc => "Toggle FontLoader support", ditto
Kunihiko Sakamoto
Comment 9 2013-03-04 02:08:44 PST
Created attachment 191178 [details] Patch3, fixed flag descriptions
Benjamin Poulain
Comment 10 2013-03-04 02:11:22 PST
Comment on attachment 191178 [details] Patch3, fixed flag descriptions LGTM
Kunihiko Sakamoto
Comment 11 2013-03-04 02:12:57 PST
Thank you for the review!
WebKit Review Bot
Comment 12 2013-03-04 03:42:58 PST
Comment on attachment 191178 [details] Patch3, fixed flag descriptions Clearing flags on attachment: 191178 Committed r144614: <http://trac.webkit.org/changeset/144614>
WebKit Review Bot
Comment 13 2013-03-04 03:43:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.