Summary: | Attempt to fix the Qt build after r144498 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, jbriance, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 106127 | ||||||
Attachments: |
|
Description
Adam Barth
2013-03-03 10:18:09 PST
Created attachment 191137 [details]
Patch
Comment on attachment 191137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191137&action=review > Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:276 > + append(String("<qxmlstreamdummyelement>").impl()); This could be StringImpl::create(), but this is also fine. I'm going to leave it that way for simplicity. Comment on attachment 191137 [details] Patch Clearing flags on attachment: 191137 Committed r144578: <http://trac.webkit.org/changeset/144578> All reviewed patches have been landed. Closing bug. (In reply to comment #0) > Attempt to fix the Qt build after r144498 Build is ok now: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/21413 Thanks a lot for your reactivity (even on a sunday) ! |