| Summary: | PDFPlugin: Rename delegate method from openWithPreview to openWithNativeApplication | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | Assignee: | Nobody <webkit-unassigned> | |||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2013-03-02 17:03:47 PST
Created attachment 191121 [details]
patch
Comment on attachment 191121 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=191121&action=review r=me assuming there is a good answer to the question below. > Source/WebKit2/ChangeLog:11 > + Rename from openWithPreview to openWithNativeApplication for accuracy. I don't understand this explanation. The delegate name should match what PDFLayerController expects, even if we find that inaccurate. Did PDFLayerController change? If it did, do we need to support both names for the time being? (In reply to comment #2) > (From update of attachment 191121 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191121&action=review > > r=me assuming there is a good answer to the question below. > > > Source/WebKit2/ChangeLog:11 > > + Rename from openWithPreview to openWithNativeApplication for accuracy. > > I don't understand this explanation. The delegate name should match what PDFLayerController expects, even if we find that inaccurate. > > Did PDFLayerController change? If it did, do we need to support both names for the time being? Yes, it changed, long ago. It sends whichever the delegate implements. |