Bug 111251 – Web Inspector: remove existing LayerTreeAgent protocol APIs

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Antoine Quint]

In preparation for https://bugs.webkit.org/show_bug.cgi?id=110407 and the series of patches needed to address it, we should start by cleaning up the existing getLayerTree() and nodeIdForLayerId() APIs exposed by the LayerTreeAgent. This will make further patches easier to read.

[Radar WebKit Bug Importer]

<rdar://problem/13331811>

[Antoine Quint]

Created attachment 191106 [details]
Patch

[WebKit Review Bot]

Comment on attachment 191106 [details]
Patch

Clearing flags on attachment: 191106

Committed r144624: <http://trac.webkit.org/changeset/144624>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Antonio Gomes]

Did this cause 

In file included from /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:36:
/Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.h:81:11: error: private field 'm_inspectedPage' is not used [-Werror,-Wunused-private-field]
    Page* m_inspectedPage;
          ^
1 error generated.


XCode 4.6.x?

[Antoine Quint]

(In reply to comment #5)
> Did this cause 
> 
> In file included from /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:36:
> /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.h:81:11: error: private field 'm_inspectedPage' is not used [-Werror,-Wunused-private-field]
>     Page* m_inspectedPage;
>           ^
> 1 error generated.
> 
> 
> XCode 4.6.x?

Probably, I'm looking into it right now.

[Antoine Quint]

(In reply to comment #6)
> (In reply to comment #5)
> > Did this cause 
> > 
> > In file included from /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:36:
> > /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.h:81:11: error: private field 'm_inspectedPage' is not used [-Werror,-Wunused-private-field]
> >     Page* m_inspectedPage;
> >           ^
> > 1 error generated.
> > 
> > 
> > XCode 4.6.x?
> 
> Probably, I'm looking into it right now.

Fix went in http://trac.webkit.org/changeset/144631.