Bug 111223

Summary:

[V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Kentaro Hara

Reported 2013-03-01 14:43:55 PST

HTMLDocument::getNamedProperty() is used by DOMWindowShell. It can be a static method in DOMWindowShell.

Attachments
Patch (5.59 KB, patch) 2013-03-01 14:45 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2013-03-01 14:45:01 PST

Adam Barth

Comment 2 2013-03-02 23:20:45 PST

Comment on attachment 191039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191039&action=review > Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:435 > + return v8Undefined(); Should we pass the isolate to v8Undefined ?

Kentaro Hara

Comment 3 2013-03-03 15:54:44 PST

Kentaro Hara

Comment 4 2013-03-03 16:00:51 PST

(In reply to comment #2) > (From update of attachment 191039 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191039&action=review > > > Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:435 > > + return v8Undefined(); > > Should we pass the isolate to v8Undefined ? I have to fix it when I fix bug 104088. Currently v8::Undefined(), v8Undefined() and Handle<Value>() are mixed inconsistently.

Note You need to log in before you can comment on or make changes to this bug.