Bug 111214

Summary:

[V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2013-03-01 13:00:38 PST

$implContentDecls stores generated code that is put in a namespace 'XXXV8Internal'. For clarification, it should be renamed to $implContentInternals.

Comment 1 Kentaro Hara 2013-03-01 13:02:12 PST

Created attachment 191019 [details]
Patch

Comment 2 Adam Barth 2013-03-02 23:12:35 PST

Comment on attachment 191019 [details]
Patch

ok

Comment 3 Adam Barth 2013-03-02 23:13:07 PST

I'm not sure the new name is that much better than the old name, but it doesn't seem worse either.

Comment 4 Kentaro Hara 2013-03-03 16:11:28 PST

Committed r144588: <http://trac.webkit.org/changeset/144588>