WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111214
[V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=111214
Summary
[V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm
Kentaro Hara
Reported
2013-03-01 13:00:38 PST
$implContentDecls stores generated code that is put in a namespace 'XXXV8Internal'. For clarification, it should be renamed to $implContentInternals.
Attachments
Patch
(53.35 KB, patch)
2013-03-01 13:02 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2013-03-01 13:02:12 PST
Created
attachment 191019
[details]
Patch
Adam Barth
Comment 2
2013-03-02 23:12:35 PST
Comment on
attachment 191019
[details]
Patch ok
Adam Barth
Comment 3
2013-03-02 23:13:07 PST
I'm not sure the new name is that much better than the old name, but it doesn't seem worse either.
Kentaro Hara
Comment 4
2013-03-03 16:11:28 PST
Committed
r144588
: <
http://trac.webkit.org/changeset/144588
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug