Bug 111214 - [V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm
Summary: [V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-01 13:00 PST by Kentaro Hara
Modified: 2013-03-03 16:11 PST (History)
3 users (show)

See Also:

Attachments
Patch (53.35 KB, patch)
2013-03-01 13:02 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-03-01 13:00:38 PST 
$implContentDecls stores generated code that is put in a namespace 'XXXV8Internal'. For clarification, it should be renamed to $implContentInternals.
Comment 1 Kentaro Hara 2013-03-01 13:02:12 PST 
Created attachment 191019 [details]
Patch
Comment 2 Adam Barth 2013-03-02 23:12:35 PST 
Comment on attachment 191019 [details]
Patch

ok
Comment 3 Adam Barth 2013-03-02 23:13:07 PST 
I'm not sure the new name is that much better than the old name, but it doesn't seem worse either.
Comment 4 Kentaro Hara 2013-03-03 16:11:28 PST 
Committed r144588: <http://trac.webkit.org/changeset/144588>