Bug 11116

Summary: Move cacheGlobalObject into KJS namespace
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: PlatformAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Other   
OS: OS X 10.4   
Attachments:
Description Flags
Initial patch
none
Updated patch eric: review+

Nikolas Zimmermann
Reported 2006-10-02 02:58:08 PDT
If cacheGlobalObject lives in the root namespace, it makes trouble. The KJS_GCC_ROOT_NS_HACK was introduced to work around these troubles, though it breaks with older gcc3 compilers, and it's just not worth. We can just as well kill it, and fix it properly. That also makes it possible to remove the friendship between cacheGlobalObject and tons of generated JS wrapper classes. Attaching a patch for this, which also fixes some strange problems regarding to gcc3 and image-decoders/platform/png.
Attachments
Initial patch (24.29 KB, patch)
2006-10-02 02:58 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch (30.94 KB, patch)
2006-10-02 03:12 PDT, Nikolas Zimmermann 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2006-10-02 02:58:46 PDT
Created attachment 10862 [details] Initial patch A first try :-)
Nikolas Zimmermann
Comment 2 2006-10-02 03:12:09 PDT
Created attachment 10863 [details] Updated patch Forgot the whitespace cleanup in kjs/lookup.h
Eric Seidel (no email)
Comment 3 2006-10-02 03:14:15 PDT
Comment on attachment 10863 [details] Updated patch Looks fine. r=me. (mjs also looked).
Eric Seidel (no email)
Comment 4 2006-10-02 03:30:12 PDT
r16711
Note You need to log in before you can comment on or make changes to this bug.