Bug 11116 - Move cacheGlobalObject into KJS namespace
Summary: Move cacheGlobalObject into KJS namespace
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: Other OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on:
Reported: 2006-10-02 02:58 PDT by Nikolas Zimmermann
Modified: 2006-10-02 03:30 PDT (History)
0 users

See Also:

Initial patch (24.29 KB, patch)
2006-10-02 02:58 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Updated patch (30.94 KB, patch)
2006-10-02 03:12 PDT, Nikolas Zimmermann
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2006-10-02 02:58:08 PDT
If cacheGlobalObject lives in the root namespace, it makes trouble.
The KJS_GCC_ROOT_NS_HACK was introduced to work around these troubles,
though it breaks with older gcc3 compilers, and it's just not worth.

We can just as well kill it, and fix it properly. That also makes
it possible to remove the friendship between cacheGlobalObject and
tons of generated JS wrapper classes.

Attaching a patch for this, which also fixes some strange
problems regarding to gcc3 and image-decoders/platform/png.
Comment 1 Nikolas Zimmermann 2006-10-02 02:58:46 PDT
Created attachment 10862 [details]
Initial patch

A first try :-)
Comment 2 Nikolas Zimmermann 2006-10-02 03:12:09 PDT
Created attachment 10863 [details]
Updated patch

Forgot the whitespace cleanup in kjs/lookup.h
Comment 3 Eric Seidel (no email) 2006-10-02 03:14:15 PDT
Comment on attachment 10863 [details]
Updated patch

Looks fine.  r=me.  (mjs also looked).
Comment 4 Eric Seidel (no email) 2006-10-02 03:30:12 PDT