Bug 111140

Summary: Coordinated Graphics API tests for Efl
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: WebKit2Assignee: Luiz Agostini <luiz>
Status: RESOLVED INVALID    
Severity: Normal CC: enmi.lee, gyuyoung.kim, noam, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 111139, 110323    
Bug Blocks:    
Attachments:
Description Flags
patch
eflews.bot: commit-queue-
patch
none
patch none

Description Luiz Agostini 2013-02-28 21:59:56 PST 
Coordinated Graphics API tests for Efl
Comment 1 Luiz Agostini 2013-03-15 00:11:58 PDT 
Created attachment 193246 [details]
patch
Comment 2 EFL EWS Bot 2013-03-15 00:18:53 PDT 
Comment on attachment 193246 [details]
patch

Attachment 193246 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17116283
Comment 3 Luiz Agostini 2013-03-15 01:05:19 PDT 
Created attachment 193254 [details]
patch
Comment 4 WebKit Review Bot 2013-03-15 01:07:35 PDT 
Attachment 193254 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/PlatformEfl.cmake', u'Source/WebKit2/UIProcess/API/C/efl/WKView.cpp', u'Source/WebKit2/UIProcess/API/C/efl/WKView.h', u'Source/WebKit2/UIProcess/API/efl/ewk_view.cpp', u'Source/WebKit2/UIProcess/API/efl/ewk_view.h', u'Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_coordinated_view.cpp', u'Source/WebKit2/UIProcess/efl/WebView.h']" exit_code: 1
Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_coordinated_view.cpp:60:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Luiz Agostini 2013-03-15 01:13:59 PDT 
Created attachment 193255 [details]
patch
Comment 6 Kenneth Rohde Christiansen 2013-03-18 03:52:00 PDT 
Comment on attachment 193255 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193255&action=review

LGTM

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:854
>  
> +EAPI const void* ewk_view_WKView_get(const Evas_Object* ewkView);
> +

Similar method already exists!
Comment 7 Mikhail Pozdnyakov 2013-03-18 04:57:04 PDT 
Comment on attachment 193255 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193255&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:853
> +EAPI const void* ewk_view_WKView_get(const Evas_Object* ewkView);

it cannot be part of public API.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_coordinated_view.cpp:42
> +static Ecore_Timer* timeoutTimer = 0;

=0 can be omitted

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_coordinated_view.cpp:60
> +    const char* hitTestHtml =

const char hitTestHtml[]
Comment 8 Noam Rosenthal 2013-10-11 08:05:50 PDT 
This has been resolved in a diferent way by the nix port.