Bug 111139 – [WK2] Create a port independent test view for Coordinated Graphics

• Component: WebKit2
• Status: NEW

[Luiz Agostini]

It would be nice to have a very simple Coordinated Graphics view that is independent from Qt or Efl.
That view would be used on port independent API tests for Coordinated Graphics.

[Luiz Agostini]

Created attachment 190910 [details]
patch

[Luiz Agostini]

the patch is not expected to build without bug #110323.

[EFL EWS Bot]

Comment on attachment 190910 [details]
patch

Attachment 190910 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/16795388

[Luiz Agostini]

Created attachment 191714 [details]
patch

[Kenneth Rohde Christiansen]

Comment on attachment 191714 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191714&action=review

> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedView.cpp:47
> +class CoordinatedPageClient : public WebKit::PageClient {

I dont see how this will work together with the EFL WKView. Can't you not just test it using EFL for now and we turn our WKView cross platform later

> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedView.cpp:60
> +    virtual void didReceiveMessageFromNavigatorQtObject(const String&) { notImplemented(); }

doesnt look so port independent.

[Luiz Agostini]

(In reply to comment #5)
> (From update of attachment 191714 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191714&action=review
> 
> > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedView.cpp:47
> > +class CoordinatedPageClient : public WebKit::PageClient {
> 
> I dont see how this will work together with the EFL WKView. Can't you not just test it using EFL for now and we turn our WKView cross platform later

It would be just a simple view for tests. Just want to be less intrusive. For example, having this view, WKView does not need to expose its WKCoordinatedScene for us to be able to test.

[EFL EWS Bot]

Comment on attachment 191714 [details]
patch

Attachment 191714 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/183121

[Noam Rosenthal]

Comment on attachment 191714 [details]
patch

Doesn't seem relevant anymore :)