Summary: | [WK2] Create a port independent test view for Coordinated Graphics | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luiz Agostini <luiz> | ||||||
Component: | WebKit2 | Assignee: | Luiz Agostini <luiz> | ||||||
Status: | NEW --- | ||||||||
Severity: | Normal | CC: | cdumez, cmarcelo, eflews.bot, gyuyoung.kim, gyuyoung.kim, helder.correia, kenneth, mikhail.pozdnyakov, noam, rakuco, webkit.review.bot, zeno | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 110323 | ||||||||
Bug Blocks: | 111140 | ||||||||
Attachments: |
|
Description
Luiz Agostini
2013-02-28 21:59:06 PST
Created attachment 190910 [details]
patch
the patch is not expected to build without bug #110323. Comment on attachment 190910 [details] patch Attachment 190910 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16795388 Created attachment 191714 [details]
patch
Comment on attachment 191714 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=191714&action=review > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedView.cpp:47 > +class CoordinatedPageClient : public WebKit::PageClient { I dont see how this will work together with the EFL WKView. Can't you not just test it using EFL for now and we turn our WKView cross platform later > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedView.cpp:60 > + virtual void didReceiveMessageFromNavigatorQtObject(const String&) { notImplemented(); } doesnt look so port independent. (In reply to comment #5) > (From update of attachment 191714 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191714&action=review > > > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedView.cpp:47 > > +class CoordinatedPageClient : public WebKit::PageClient { > > I dont see how this will work together with the EFL WKView. Can't you not just test it using EFL for now and we turn our WKView cross platform later It would be just a simple view for tests. Just want to be less intrusive. For example, having this view, WKView does not need to expose its WKCoordinatedScene for us to be able to test. Comment on attachment 191714 [details] patch Attachment 191714 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/183121 Comment on attachment 191714 [details]
patch
Doesn't seem relevant anymore :)
|