Bug 111106

Summary:

CodeBlock::valueProfile() has a bogus assertion

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mhahnenberg: review+

Description Filip Pizlo 2013-02-28 13:25:00 PST

<rdar://problem/13131427>

Comment 1 Filip Pizlo 2013-02-28 13:29:08 PST

Created attachment 190797 [details]
the patch

Comment 2 Filip Pizlo 2013-02-28 13:30:01 PST

Comment on attachment 190797 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190797&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        This was just a bad assertion: m_bytecodeOffset means that the value profile is constructed but not initialized.

should say:

This was just a bad assertion: m_bytecodeOffset == -1 means that the value profile is constructed but not initialized.

Comment 3 Mark Hahnenberg 2013-02-28 13:30:46 PST

Comment on attachment 190797 [details]
the patch

r=me

Comment 4 Filip Pizlo 2013-02-28 13:33:21 PST

Landed in http://trac.webkit.org/changeset/144356