Bug 111090

Summary: [texmap] Remove redundant defines on TextureMapperGL
Product: WebKit Reporter: Bruno Abinader (history only) <bruno.abinader>
Component: Layout and RenderingAssignee: Bruno Abinader (history only) <bruno.abinader>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, igor.oliveira, luiz, noam, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108716    
Attachments:
Description Flags
Patch none

Description Bruno Abinader (history only) 2013-02-28 10:32:28 PST 
Used inside TextureMapperGL::updateContentsNoSwizzle(), the driverSupportsSubImage() function already uses OpenGL ES defines to return correct support, thus no need for additional defines.
Comment 1 Bruno Abinader (history only) 2013-02-28 10:33:57 PST 
Created attachment 190753 [details]
Patch

Proposed patch
Comment 2 Antonio Gomes 2013-02-28 10:58:42 PST 
Comment on attachment 190753 [details]
Patch

Igor?
Comment 3 Igor Trindade Oliveira 2013-02-28 12:39:50 PST 
cq'ed
Comment 4 WebKit Review Bot 2013-02-28 13:11:07 PST 
Comment on attachment 190753 [details]
Patch

Rejecting attachment 190753 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190753, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:

fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2

Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Full output: http://webkit-commit-queue.appspot.com/results/16666457
Comment 5 Bruno Abinader (history only) 2013-02-28 13:17:07 PST 
Comment on attachment 190753 [details]
Patch

Commit-queue seems sick, trying again...
Comment 6 WebKit Review Bot 2013-02-28 13:39:42 PST 
Comment on attachment 190753 [details]
Patch

Clearing flags on attachment: 190753

Committed r144359: <http://trac.webkit.org/changeset/144359>
Comment 7 WebKit Review Bot 2013-02-28 13:39:45 PST 
All reviewed patches have been landed.  Closing bug.