Bug 11109 – REGRESSION (r15471): menus are offset on eink.com

• Component: DOM
• Status: RESOLVED FIXED

The drop-down menus on eink.com are offset by 10px up and to the left since r15471 (fix for bug 9943). It turns out that the body's offsetLeft and offsetTop should be 0 (this part was fixed), but consequently the body's margins should be included in the offsetLeft/Top of any element whose offsetParent is the body. See the attached test case.

Created attachment 10855 [details]
Test case (expected values are based on Firefox and WinIE)

Created attachment 12289 [details]
[WIP] Patch without change log

The behavior is slightly more subtle - although the body element is always in the offsetParent hierarchy, if it's static it's skipped over in offsetTop/Left computation. This patch fixes eink.com and doesn't fail any layout tests, but I still need to verify that it doesn't silently break any of the tests that use offset*.

[Dave Hyatt]

Double check quirks vs. strict mode here please to make sure the behavior in WinIE stays the same.

(In reply to comment #3)
> Double check quirks vs. strict mode here please to make sure the behavior in
> WinIE stays the same.
> 

Firefox behaves the same in both modes. IE's behavior is totally different: in strict mode it gives the body's true offsets, and in quirks mode it gives 0 and skips over the body regardless of whether it's positioned or not.

*** Bug 12294 has been marked as a duplicate of this bug. ***

[David Kilzer (:ddkilzer)]

Per Bug 12294 Comment #5:

<rdar://problem/4928707>

I think this is affecting the new format of Google Image Search results: the box around the hovered result is broken.

[David Kilzer (:ddkilzer)]

(In reply to comment #7)
> I think this is affecting the new format of Google Image Search results: the
> box around the hovered result is broken.

That sounds like Bug 12330.

[Darin Adler]

<rdar://problem/4824760>

Created attachment 12674 [details]
Match Firefox's offset{Left,Top} behavior for objects whose containing block is the root

Includes change log, layout test, and updated tests or results for tests that were relying on the old behavior.

[Maciej Stachowiak]

How does this compare to how IE does it? This may require a layout expert like hyatt to review.

[Darin Adler]

Comment on attachment 12674 [details]
Match Firefox's offset{Left,Top} behavior for objects whose containing block is the root

r=me

[Mark Rowe (bdash)]

Landed in r19149.

*** Bug 12330 has been marked as a duplicate of this bug. ***