Bug 111064

Summary: Web Inspector: fix code-mirror experiment to work in debug mode
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Andrey Lushnikov
Reported 2013-02-28 03:23:50 PST
fix code-mirror experiment to work with "debug_devtools" flag been set to 1
Attachments
Patch (10.59 KB, patch)
2013-02-28 03:34 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (1.86 KB, patch)
2013-03-01 01:00 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-02-28 03:34:49 PST
Created attachment 190693 [details] Patch
Pavel Feldman
Comment 2 2013-02-28 03:38:15 PST
Comment on attachment 190693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190693&action=review > Source/WebCore/WebCore.gypi:5208 > + 'inspector/front-end/CodeMirrorTextEditor.js', How come it is in two places at a time? > Source/WebCore/WebCore.gypi:5466 > + 'webinspector_codemirror_inline_files': [ We had no notion of inline files, just modules. Why making things complex? > Source/WebCore/WebCore.gypi:5478 > + 'webinspector_debug_standalone_files': [ This hurts modularity - this is about cm, not standalone? > Source/WebKit/chromium/WebKit.gyp:856 > + ['include', '/cm/'], I think we should either split all modules by folders or not do it at all.
Andrey Lushnikov
Comment 3 2013-03-01 01:00:47 PST
Created attachment 190904 [details] Patch
WebKit Review Bot
Comment 4 2013-03-01 01:39:44 PST
Comment on attachment 190904 [details] Patch Clearing flags on attachment: 190904 Committed r144428: <http://trac.webkit.org/changeset/144428>
WebKit Review Bot
Comment 5 2013-03-01 01:39:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.