Bug 111049

Summary: Cleanup: XSSAuditor form[action] tests should be manually executable.
Product: WebKit Reporter: Mike West <mkwst>
Component: New BugsAssignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Trivial CC: dbates, webkit.review.bot
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mike West
Reported 2013-02-28 01:00:43 PST
XSSAuditor form[action] tests should be manually executable.
Attachments
Patch (1.69 KB, patch)
2013-02-28 01:03 PST, Mike West 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2013-02-28 01:03:36 PST
Created attachment 190674 [details] Patch
Mike West
Comment 2 2013-02-28 01:06:14 PST
Following up on dbates' recommendation in https://bugs.webkit.org/show_bug.cgi?id=110975, I'm splitting out this drive-by nit into a separate patch. In the future, migrating these tests to 'js-test-pre.js' seems like a good thing to do, but for the moment, simply ensuring that they work correctly when run manually is worthwhile (and trivial).
Daniel Bates
Comment 3 2013-02-28 01:32:02 PST
Comment on attachment 190674 [details] Patch Thank you Mike for splitting this off into a separate patch.
Mike West
Comment 4 2013-02-28 01:34:22 PST
(In reply to comment #3) > (From update of attachment 190674 [details]) > Thank you Mike for splitting this off into a separate patch. Tiny patches are cheap. :) Thanks for taking a look!
WebKit Review Bot
Comment 5 2013-02-28 02:09:23 PST
Comment on attachment 190674 [details] Patch Clearing flags on attachment: 190674 Committed r144282: <http://trac.webkit.org/changeset/144282>
WebKit Review Bot
Comment 6 2013-02-28 02:09:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.