Summary: | [EFL][WK2] Enable interactive form validation for email and url input type validation | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||||
Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 111534 | ||||||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2013-02-27 17:46:10 PST
Created attachment 190630 [details]
Patch
Created attachment 190631 [details]
Screenshot when inputing wrong email type
Comment on attachment 190630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190630&action=review I sign off on this for WK2. > Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:494 > - return String::fromUTF8("type mismatch"); > + return String::fromUTF8("Please enter an email address"); > } > > String validationMessageTypeMismatchForMultipleEmailText() > { > - return String::fromUTF8("type mismatch"); > + return String::fromUTF8("Please enter an email address"); > } > > String validationMessageTypeMismatchForURLText() > { > - return String::fromUTF8("type mismatch"); > + return String::fromUTF8("Please enter a URL"); You could return ASCIILiteral here. > Source/WebCore/platform/efl/RenderThemeEfl.cpp:760 > // FIXME: We need to support other types. > - return type == InputTypeNames::range(); > + return type == InputTypeNames::range() > + || type == InputTypeNames::email() Still need the FIXME? Created attachment 191615 [details]
Patch
Benjamin, thank you for your review. I fix all. CC'ing Laszlo and Chris. Could you review this patch. This patch is signed off by Benjamin. Comment on attachment 191615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191615&action=review > Source/WebCore/platform/efl/RenderThemeEfl.cpp:-758 > - // FIXME: We need to support other types. I think the FIXME should stay. We still need to support way more types (e.g. search, datetime, color, telephone, ...) Created attachment 191653 [details]
Patch
(In reply to comment #6) > (From update of attachment 191615 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191615&action=review > > > Source/WebCore/platform/efl/RenderThemeEfl.cpp:-758 > > - // FIXME: We need to support other types. > > I think the FIXME should stay. We still need to support way more types (e.g. search, datetime, color, telephone, ...) Ok, I don't mind to keep it. Created attachment 191681 [details]
Patch
Comment on attachment 191681 [details]
Patch
LGTM
Comment on attachment 191681 [details]
Patch
r=me. Signed off by Benjamin for WK2.
Comment on attachment 191681 [details] Patch Clearing flags on attachment: 191681 Committed r145024: <http://trac.webkit.org/changeset/145024> All reviewed patches have been landed. Closing bug. |