Bug 111026 – [EFL][WK2] Enable interactive form validation for email and url input type validation

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Gyuyoung Kim]

Chromium, blackberry and WK1 gtk ports already check if input values are valid by enabling this feature. I would like to enable this functionality for WebKit2 EFL port. First, this patch supports if email and url type is valid.

[Gyuyoung Kim]

Created attachment 190630 [details]
Patch

[Gyuyoung Kim]

Created attachment 190631 [details]
Screenshot when inputing wrong email type

[Benjamin Poulain]

Comment on attachment 190630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190630&action=review

I sign off on this for WK2.

> Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:494
> -    return String::fromUTF8("type mismatch");
> +    return String::fromUTF8("Please enter an email address");
>  }
>  
>  String validationMessageTypeMismatchForMultipleEmailText()
>  {
> -    return String::fromUTF8("type mismatch");
> +    return String::fromUTF8("Please enter an email address");
>  }
>  
>  String validationMessageTypeMismatchForURLText()
>  {
> -    return String::fromUTF8("type mismatch");
> +    return String::fromUTF8("Please enter a URL");

You could return ASCIILiteral here.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:760
>      // FIXME: We need to support other types.
> -    return type == InputTypeNames::range();
> +    return type == InputTypeNames::range()
> +        || type == InputTypeNames::email()

Still need the FIXME?

[Gyuyoung Kim]

Created attachment 191615 [details]
Patch

[Gyuyoung Kim]

Benjamin, thank you for your review. I fix all.

CC'ing Laszlo and Chris. Could you review this patch. This patch is signed off by Benjamin.

[Chris Dumez]

Comment on attachment 191615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191615&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:-758
> -    // FIXME: We need to support other types.

I think the FIXME should stay. We still need to support way more types (e.g. search, datetime, color, telephone, ...)

[Gyuyoung Kim]

Created attachment 191653 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #6)
> (From update of attachment 191615 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191615&action=review
> 
> > Source/WebCore/platform/efl/RenderThemeEfl.cpp:-758
> > -    // FIXME: We need to support other types.
> 
> I think the FIXME should stay. We still need to support way more types (e.g. search, datetime, color, telephone, ...)

Ok, I don't mind to keep it.

[Gyuyoung Kim]

Created attachment 191681 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 191681 [details]
Patch

LGTM

[Laszlo Gombos]

Comment on attachment 191681 [details]
Patch

r=me. Signed off by Benjamin for WK2.

[WebKit Review Bot]

Comment on attachment 191681 [details]
Patch

Clearing flags on attachment: 191681

Committed r145024: <http://trac.webkit.org/changeset/145024>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.