Summary: | Initialize page visibility after creating WebKitTestRunner WebView on Mac | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kiran Muppala <cmuppala> | ||||
Component: | Tools / Tests | Assignee: | Kiran Muppala <cmuppala> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, simon.fraser, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Kiran Muppala
2013-02-27 17:26:06 PST
(In reply to comment #2) > https://bugs.webkit.org/show_bug.cgi?id=107494 Link to bug which added window occlusion notifications. Created attachment 190628 [details]
Patch
Comment on attachment 190628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190628&action=review Does DRT also need fixing? > Tools/WebKitTestRunner/TestController.cpp:487 > + setVisibilityState(kWKPageVisibilityStateVisible, true); Hard to know what the 'true' means reading this. Comment on attachment 190628 [details] Patch Clearing flags on attachment: 190628 Committed r144259: <http://trac.webkit.org/changeset/144259> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > (From update of attachment 190628 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190628&action=review > > Does DRT also need fixing? > Not currently because window occlusion notifications are only available in WebKit2. > > Tools/WebKitTestRunner/TestController.cpp:487 > > + setVisibilityState(kWKPageVisibilityStateVisible, true); > > Hard to know what the 'true' means reading this. I considered adding a inline comment /*isInitialState*/, but then in a previous WebKit2 patch that style was frowned upon. I can find several such instances of inline comment in WebCore but just one in WebKit2. So, I left it out. |