| Summary: | [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dglazkov, enne, fishd, jochen, peter+ews, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 111113, 111146 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
James Robinson
2013-02-27 15:01:44 PST
Created attachment 190612 [details]
Patch
This is a bit insane but seems to work. Depends on https://codereview.chromium.org/12330184/ landing + rolling in or this won't compile. Comment on attachment 190612 [details] Patch Attachment 190612 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16802164 Comment on attachment 190612 [details] Patch Attachment 190612 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16795169 Created attachment 190624 [details]
rejigger WebTestProxyBase to avoid WebViewClient indirection
Comment on attachment 190624 [details] rejigger WebTestProxyBase to avoid WebViewClient indirection Attachment 190624 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16793166 Comment on attachment 190624 [details] rejigger WebTestProxyBase to avoid WebViewClient indirection Attachment 190624 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16817260 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Any idea how to implement this in content shell (where WebViewHost is RenderViewImpl) Comment on attachment 190624 [details] rejigger WebTestProxyBase to avoid WebViewClient indirection Attachment 190624 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/16802277 (In reply to comment #9) > Any idea how to implement this in content shell (where WebViewHost is RenderViewImpl) There's no need to AFAIK. In content shell, the compositor embedding is handled by content::RenderWidget which uses content::RenderWidgetCompositor to deal with all of this. Committed r144398: <http://trac.webkit.org/changeset/144398> |