Bug 111017

Summary: [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, enne, fishd, jochen, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 111113, 111146    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
rejigger WebTestProxyBase to avoid WebViewClient indirection abarth: review+, webkit.review.bot: commit-queue-

James Robinson
Reported 2013-02-27 15:01:44 PST
[chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
Attachments
Patch (3.52 KB, patch)
2013-02-27 15:03 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
rejigger WebTestProxyBase to avoid WebViewClient indirection (4.75 KB, patch)
2013-02-27 15:58 PST, James Robinson 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-02-27 15:03:15 PST
Created attachment 190612 [details] Patch
James Robinson
Comment 2 2013-02-27 15:04:32 PST
This is a bit insane but seems to work. Depends on https://codereview.chromium.org/12330184/ landing + rolling in or this won't compile.
WebKit Review Bot
Comment 3 2013-02-27 15:07:17 PST
Comment on attachment 190612 [details] Patch Attachment 190612 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16802164
WebKit Review Bot
Comment 4 2013-02-27 15:14:59 PST
Comment on attachment 190612 [details] Patch Attachment 190612 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16795169
James Robinson
Comment 5 2013-02-27 15:58:53 PST
Created attachment 190624 [details] rejigger WebTestProxyBase to avoid WebViewClient indirection
WebKit Review Bot
Comment 6 2013-02-27 16:11:48 PST
Comment on attachment 190624 [details] rejigger WebTestProxyBase to avoid WebViewClient indirection Attachment 190624 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16793166
WebKit Review Bot
Comment 7 2013-02-27 16:16:11 PST
Comment on attachment 190624 [details] rejigger WebTestProxyBase to avoid WebViewClient indirection Attachment 190624 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16817260
WebKit Review Bot
Comment 8 2013-02-27 20:28:38 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
jochen
Comment 9 2013-02-27 22:21:44 PST
Any idea how to implement this in content shell (where WebViewHost is RenderViewImpl)
Peter Beverloo (cr-android ews)
Comment 10 2013-02-28 07:16:37 PST
Comment on attachment 190624 [details] rejigger WebTestProxyBase to avoid WebViewClient indirection Attachment 190624 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/16802277
James Robinson
Comment 11 2013-02-28 11:02:09 PST
(In reply to comment #9) > Any idea how to implement this in content shell (where WebViewHost is RenderViewImpl) There's no need to AFAIK. In content shell, the compositor embedding is handled by content::RenderWidget which uses content::RenderWidgetCompositor to deal with all of this.
James Robinson
Comment 12 2013-02-28 16:52:33 PST
Committed r144398: <http://trac.webkit.org/changeset/144398>
Note You need to log in before you can comment on or make changes to this bug.