Bug 110994

Summary: [BlackBerry] User credentials is not correctly handled
Product: WebKit Reporter: Lyon Chen <liachen>
Component: WebKit BlackBerryAssignee: Lyon Chen <liachen>
Status: RESOLVED FIXED    
Severity: Normal CC: joenotcharles, leoyang, mifenton, pnormand, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
patch for 110994
none
Fix utf8 handling none

Description Lyon Chen 2013-02-27 10:59:35 PST
Right now user credential is not correctly handled, like:

* User credentials are never deleted from CertMgr;
* User credentials are not always correctly saved/retrieved;
* User credentials for http proxy are not re-used when visiting different sites.

The reason are:
* For the first one, CertMgrWrapper didn't support removing password before, but it has since been fixed and we need to use the new API to delete user credential from CertMgr.

*For the second one, we treat encrypted text as normal text, but in fact they are just binary data, we need to treat them correctly, as binary data.

* Fot the third one, we used to save user credential combined the original url, we should not.
Comment 1 Lyon Chen 2013-02-27 11:22:23 PST
Created attachment 190561 [details]
patch for 110994
Comment 2 Yong Li 2013-02-27 12:33:47 PST
Comment on attachment 190561 [details]
patch for 110994

r+ based on leo's review
Comment 3 WebKit Review Bot 2013-02-27 12:52:32 PST
Comment on attachment 190561 [details]
patch for 110994

Clearing flags on attachment: 190561

Committed r144229: <http://trac.webkit.org/changeset/144229>
Comment 4 WebKit Review Bot 2013-02-27 12:52:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Alberto Garcia 2013-02-27 23:55:43 PST
Created attachment 190667 [details]
Fix utf8 handling

WTF::String::utf8 no longer receives a bool, see bug 101678.

http://trac.webkit.org/changeset/134173/trunk/Source/WTF/wtf/text/WTFString.h
Comment 6 Philippe Normand 2013-02-28 00:31:09 PST
Should this bug be reopened?
Comment 7 Lyon Chen 2013-02-28 07:37:47 PST
(In reply to comment #6)
> Should this bug be reopened?

Thanks for reminding me of this change, it seems our repo had not synced with upstream for quite a while now.

Re-open this for a new patch to adapt to the WTF::String::utf8() interface change.
Comment 8 Lyon Chen 2013-02-28 08:02:14 PST
(In reply to comment #5)
> Created an attachment (id=190667) [details]
> Fix utf8 handling
> 
> WTF::String::utf8 no longer receives a bool, see bug 101678.
> 
> http://trac.webkit.org/changeset/134173/trunk/Source/WTF/wtf/text/WTFString.h

The patch looks good to me.
Comment 9 WebKit Review Bot 2013-02-28 08:43:55 PST
Comment on attachment 190667 [details]
Fix utf8 handling

Clearing flags on attachment: 190667

Committed r144316: <http://trac.webkit.org/changeset/144316>
Comment 10 WebKit Review Bot 2013-02-28 08:43:58 PST
All reviewed patches have been landed.  Closing bug.