Bug 110988

Summary:

[CSS Grid Layout] Add parsing for grid-{start|before}

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

Layout and Rendering

Assignee:

Julien Chaffraix <jchaffraix>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, dglazkov, eric, esprehn+autocc, macpherson, menard, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

103314

Attachments:

Description	Flags
Proposed implementation 1: Added the properties and refactored the internal to be aligned with grid-{start\|end}.	none
Proposed implementation 2: Same as 1, without the wrong test rebaselines.	none

Julien Chaffraix

Reported 2013-02-27 09:10:51 PST

As discussed in bug 110777, in order to support spanning and to properly parse the shorthands grid-{row|column}. We need to support and switch our internal representation to using grid-{start|end} instead of the current design which is based on grid-{row|column}.

Attachments
Proposed implementation 1: Added the properties and refactored the internal to be aligned with grid-{start\|end}. (39.82 KB, patch) 2013-02-27 09:23 PST, Julien Chaffraix	no flags	Details Formatted Diff Diff
Proposed implementation 2: Same as 1, without the wrong test rebaselines. (36.64 KB, patch) 2013-02-27 11:23 PST, Julien Chaffraix	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Julien Chaffraix

Comment 1 2013-02-27 09:23:03 PST

Created attachment 190541 [details] Proposed implementation 1: Added the properties and refactored the internal to be aligned with grid-{start|end}.

WebKit Review Bot

Comment 2 2013-02-27 10:59:57 PST

Comment on attachment 190541 [details] Proposed implementation 1: Added the properties and refactored the internal to be aligned with grid-{start|end}. Attachment 190541 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16675178 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html

Julien Chaffraix

Comment 3 2013-02-27 11:23:55 PST

Created attachment 190562 [details] Proposed implementation 2: Same as 1, without the wrong test rebaselines.

WebKit Review Bot

Comment 4 2013-03-04 15:09:51 PST

Comment on attachment 190562 [details] Proposed implementation 2: Same as 1, without the wrong test rebaselines. Clearing flags on attachment: 190562 Committed r144681: <http://trac.webkit.org/changeset/144681>

WebKit Review Bot

Comment 5 2013-03-04 15:09:56 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.