Bug 110967

Summary: Add calendar header for new calendar picker
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109439    
Attachments:
Description Flags
Patch
none
Patch none

Description Keishi Hattori 2013-02-27 04:01:05 PST
Add calendar header for new calendar picker
Comment 1 Keishi Hattori 2013-02-27 04:14:06 PST
Created attachment 190490 [details]
Patch
Comment 2 Kent Tamura 2013-02-27 06:30:41 PST
Comment on attachment 190490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190490&action=review

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1925
> +/**
> + * @return {!boolean}
> + */
> +MonthPopupButton.prototype._shouldUseShortMonth = function(maxWidth) {

Need @param for maxWidth.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1974
> +CalendarNavigationButton.DefaultrepeatingClicksStartingThreshold = 600;
> +CalendarNavigationButton.DefaultRepeatingClicksInterval = 300;

Ideally, these values should be synchronized with RenderTheme::initialAutoscrollTimerDelay and autoscrollTimerDelay.
You might want to change so later.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:2096
> +        this.calendarPicker.setCurrentMonth(this.calendarPicker.currentMonth().previous(), true);
> +    else if (sender === this._nextMonthButton)
> +        this.calendarPicker.setCurrentMonth(this.calendarPicker.currentMonth().next(), true);

boolean argument isn't good.
Comment 3 Keishi Hattori 2013-02-28 04:43:29 PST
Created attachment 190704 [details]
Patch
Comment 4 WebKit Review Bot 2013-02-28 05:07:53 PST
Comment on attachment 190704 [details]
Patch

Clearing flags on attachment: 190704

Committed r144298: <http://trac.webkit.org/changeset/144298>
Comment 5 WebKit Review Bot 2013-02-28 05:08:03 PST
All reviewed patches have been landed.  Closing bug.