Summary: | Add calendar header for new calendar picker | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keishi Hattori <keishi> | ||||||
Component: | Forms | Assignee: | Keishi Hattori <keishi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 109439 | ||||||||
Attachments: |
|
Description
Keishi Hattori
2013-02-27 04:01:05 PST
Created attachment 190490 [details]
Patch
Comment on attachment 190490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190490&action=review > Source/WebCore/Resources/pagepopups/calendarPicker.js:1925 > +/** > + * @return {!boolean} > + */ > +MonthPopupButton.prototype._shouldUseShortMonth = function(maxWidth) { Need @param for maxWidth. > Source/WebCore/Resources/pagepopups/calendarPicker.js:1974 > +CalendarNavigationButton.DefaultrepeatingClicksStartingThreshold = 600; > +CalendarNavigationButton.DefaultRepeatingClicksInterval = 300; Ideally, these values should be synchronized with RenderTheme::initialAutoscrollTimerDelay and autoscrollTimerDelay. You might want to change so later. > Source/WebCore/Resources/pagepopups/calendarPicker.js:2096 > + this.calendarPicker.setCurrentMonth(this.calendarPicker.currentMonth().previous(), true); > + else if (sender === this._nextMonthButton) > + this.calendarPicker.setCurrentMonth(this.calendarPicker.currentMonth().next(), true); boolean argument isn't good. Created attachment 190704 [details]
Patch
Comment on attachment 190704 [details] Patch Clearing flags on attachment: 190704 Committed r144298: <http://trac.webkit.org/changeset/144298> All reviewed patches have been landed. Closing bug. |