Bug 110967 – Add calendar header for new calendar picker

• Component: Forms
• Status: RESOLVED FIXED

[Keishi Hattori]

Add calendar header for new calendar picker

[Keishi Hattori]

Created attachment 190490 [details]
Patch

[Kent Tamura]

Comment on attachment 190490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190490&action=review

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1925
> +/**
> + * @return {!boolean}
> + */
> +MonthPopupButton.prototype._shouldUseShortMonth = function(maxWidth) {

Need @param for maxWidth.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1974
> +CalendarNavigationButton.DefaultrepeatingClicksStartingThreshold = 600;
> +CalendarNavigationButton.DefaultRepeatingClicksInterval = 300;

Ideally, these values should be synchronized with RenderTheme::initialAutoscrollTimerDelay and autoscrollTimerDelay.
You might want to change so later.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:2096
> +        this.calendarPicker.setCurrentMonth(this.calendarPicker.currentMonth().previous(), true);
> +    else if (sender === this._nextMonthButton)
> +        this.calendarPicker.setCurrentMonth(this.calendarPicker.currentMonth().next(), true);

boolean argument isn't good.

[Keishi Hattori]

Created attachment 190704 [details]
Patch

[WebKit Review Bot]

Comment on attachment 190704 [details]
Patch

Clearing flags on attachment: 190704

Committed r144298: <http://trac.webkit.org/changeset/144298>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.