Bug 110928

Summary: [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED WONTFIX    
Severity: Normal CC: enne, schenney, vsevik, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch enne: review+

James Robinson
Reported 2013-02-26 17:00:51 PST
[chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
Attachments
Patch (4.80 KB, patch)
2013-02-26 17:01 PST, James Robinson 		enne: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-02-26 17:01:04 PST
Created attachment 190396 [details] Patch
Adrienne Walker
Comment 2 2013-02-26 17:04:09 PST
Comment on attachment 190396 [details] Patch R=me.
James Robinson
Comment 3 2013-02-26 17:11:38 PST
Committed r144129: <http://trac.webkit.org/changeset/144129>
Vsevolod Vlasov
Comment 4 2013-02-26 23:14:52 PST
This patch has broken compilation on mac/win FAILED: clang++ -MMD -MF ... ../../webkit/compositor_bindings/web_layer_tree_view_unittest.cc -o obj/webkit/compositor_bindings/webkit_compositor_bindings_unittests.web_layer_tree_view_unittest.o ../../webkit/compositor_bindings/web_layer_tree_view_unittest.cc:28:16:error: 'didBeginFrame' marked 'override' but does not override any member functions virtual void didBeginFrame() OVERRIDE { ^ 1 error generated. ninja: build stopped: subcommand failed.
WebKit Review Bot
Comment 5 2013-02-26 23:17:36 PST
Re-opened since this is blocked by bug 110947
Vsevolod Vlasov
Comment 7 2013-02-26 23:18:20 PST
.
Note You need to log in before you can comment on or make changes to this bug.