Bug 110900

Summary: Don't add a body to platform request until necessary
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, danw, gustavo, mifenton, mrobinson, rakuco, rniwa, rwlbuis, tonikitoo, webkit-ews, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201950
Bug Depends on:    
Bug Blocks: 111034    
Attachments:
Description Flags
EWS?
webkit-ews: commit-queue-
proposed patch
webkit-ews: commit-queue-
with more Qt build fix
buildbot: commit-queue-
and don't break Mac, too beidson: review+

Alexey Proskuryakov
Reported 2013-02-26 12:29:53 PST
It is inefficient to send request body with IPC, and it is not even possible to build a body in WebProcess when NetworkProcess is in use, because WebProcess doesn't know what's inside blobs. This patch will separate body updating from request updating in ResourceRequest. For WebKit1, we will still be creating a body for client callbacks to preserve compatibility. For WebKit2, the body will only be built right before creating an NSURLConnection.
Attachments
EWS? (45.25 KB, patch)
2013-02-26 12:33 PST, Alexey Proskuryakov 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
proposed patch (59.04 KB, patch)
2013-02-26 16:41 PST, Alexey Proskuryakov 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
with more Qt build fix (59.01 KB, patch)
2013-02-26 16:54 PST, Alexey Proskuryakov 		buildbot: commit-queue-
DetailsFormatted DiffDiff
and don't break Mac, too (59.00 KB, patch)
2013-02-26 20:11 PST, Alexey Proskuryakov 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-02-26 12:33:51 PST
Created attachment 190341 [details] EWS?
Early Warning System Bot
Comment 2 2013-02-26 12:49:56 PST
Comment on attachment 190341 [details] EWS? Attachment 190341 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16775400
EFL EWS Bot
Comment 3 2013-02-26 12:57:46 PST
Comment on attachment 190341 [details] EWS? Attachment 190341 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16770445
Alexey Proskuryakov
Comment 4 2013-02-26 16:41:38 PST
Created attachment 190390 [details] proposed patch
Early Warning System Bot
Comment 5 2013-02-26 16:50:16 PST
Comment on attachment 190390 [details] proposed patch Attachment 190390 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16763028
Alexey Proskuryakov
Comment 6 2013-02-26 16:54:26 PST
Created attachment 190394 [details] with more Qt build fix
Build Bot
Comment 7 2013-02-26 17:33:43 PST
Comment on attachment 190394 [details] with more Qt build fix Attachment 190394 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16783048
Build Bot
Comment 8 2013-02-26 18:26:25 PST
Comment on attachment 190394 [details] with more Qt build fix Attachment 190394 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16806045
Build Bot
Comment 9 2013-02-26 19:16:11 PST
Comment on attachment 190394 [details] with more Qt build fix Attachment 190394 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16801034
Alexey Proskuryakov
Comment 10 2013-02-26 20:11:20 PST
Created attachment 190428 [details] and don't break Mac, too
Alexey Proskuryakov
Comment 11 2013-02-27 11:16:20 PST
Committed <http://trac.webkit.org/changeset/144216>.
Note You need to log in before you can comment on or make changes to this bug.