Bug 110862

Summary: Web Inspector: DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node
Product: WebKit Reporter: Vivek Galatage <vivekg>
Component: Web Inspector (Deprecated)Assignee: Vivek Galatage <vivekg>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Vivek Galatage
Reported 2013-02-26 02:12:36 PST
DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node. Patch follows.
Attachments
Patch (2.91 KB, patch)
2013-02-26 02:16 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (2.85 KB, patch)
2013-02-26 04:02 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2013-02-26 02:16:16 PST
Created attachment 190247 [details] Patch
Eugene Klyuchnikov
Comment 2 2013-02-26 03:34:03 PST
Comment on attachment 190247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190247&action=review > Source/WebCore/inspector/front-end/DataGrid.js:821 > + handled = nextSelectedNode ? true : false; Why deleting last row doesn't count as "handled" case?
Vivek Galatage
Comment 3 2013-02-26 03:35:52 PST
Comment on attachment 190247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190247&action=review >> Source/WebCore/inspector/front-end/DataGrid.js:821 >> + handled = nextSelectedNode ? true : false; > > Why deleting last row doesn't count as "handled" case? yes its wrong above. It should be handled always as long as there is a valid selectedNode.
Vivek Galatage
Comment 4 2013-02-26 04:02:07 PST
Created attachment 190256 [details] Patch
WebKit Review Bot
Comment 5 2013-02-26 05:44:59 PST
Comment on attachment 190256 [details] Patch Clearing flags on attachment: 190256 Committed r144047: <http://trac.webkit.org/changeset/144047>
WebKit Review Bot
Comment 6 2013-02-26 05:45:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.