Bug 110846

Summary: [JSC] static methods with Callback should not have this pointer
Product: WebKit Reporter: Kaustubh Atrawalkar <kaustubh.ra>
Component: Tools / TestsAssignee: Vineet Chaudhary (vineetc) <code.vineet>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, esprehn+autocc, ggaren, haraken, japhet, ojan.autocc, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 108196    
Attachments:
Description Flags
patch
haraken: review-, haraken: commit-queue-
updated_patch none

Kaustubh Atrawalkar
Reported 2013-02-25 22:17:06 PST
Current JSC bindings generator does not support Optional callback as method's argument. Need to add support for the same.
Attachments
patch (12.18 KB, patch)
2013-02-26 10:18 PST, Vineet Chaudhary (vineetc) 		haraken: review-
haraken: commit-queue-
DetailsFormatted DiffDiff
updated_patch (12.63 KB, patch)
2013-02-26 10:38 PST, Vineet Chaudhary (vineetc) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vineet Chaudhary (vineetc)
Comment 1 2013-02-26 10:18:58 PST
Created attachment 190322 [details] patch
Kentaro Hara
Comment 2 2013-02-26 10:23:52 PST
Comment on attachment 190322 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=190322&action=review The change to CodeGeneratorJS.pm looks good. > Source/WebCore/bindings/scripts/test/TestObj.idl:150 > + void staticMethodWithCallbackAndOptionalArg(in [Callback, Optional] TestCallback callback); > + void staticMethodWithCallbackArg(in [Callback] TestCallback callback); You need to add 'static' to these methods.
Vineet Chaudhary (vineetc)
Comment 3 2013-02-26 10:38:01 PST
Created attachment 190324 [details] updated_patch Sorry for Copypasta.
Kentaro Hara
Comment 4 2013-02-26 10:48:46 PST
Comment on attachment 190324 [details] updated_patch LGTM
Vineet Chaudhary (vineetc)
Comment 5 2013-02-26 11:28:35 PST
Comment on attachment 190324 [details] updated_patch Thanks!!
WebKit Review Bot
Comment 6 2013-02-26 13:42:00 PST
Comment on attachment 190324 [details] updated_patch Clearing flags on attachment: 190324 Committed r144101: <http://trac.webkit.org/changeset/144101>
WebKit Review Bot
Comment 7 2013-02-26 13:42:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.