Summary: | Add month popup for new calendar picker | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keishi Hattori <keishi> | ||||||
Component: | Forms | Assignee: | Keishi Hattori <keishi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 109439 | ||||||||
Attachments: |
|
Description
Keishi Hattori
2013-02-25 18:06:43 PST
Created attachment 190197 [details]
Patch
Comment on attachment 190197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190197&action=review > Source/WebCore/Resources/pagepopups/calendarPicker.js:2153 > + this.dispatchEvent("didSelectMonth", this, new Month(year, month)); "didSelectMonth" -> YearListView.EventTypeYearListViewDidSelectMonth ? > Source/WebCore/Resources/pagepopups/calendarPicker.js:2179 > + var row = parseInt(rowsWithIrregularHeight[i], 10); Is this parseInt necessary? > Source/WebCore/Resources/pagepopups/calendarPicker.js:2407 > + eventHandled = this._moveHighlightTo(Month.createFromToday()); > + eventHandled = true; Setting eventHandled twice looks bad. Created attachment 190486 [details]
Patch
Comment on attachment 190486 [details]
Patch
looks ok
Comment on attachment 190486 [details] Patch Clearing flags on attachment: 190486 Committed r144254: <http://trac.webkit.org/changeset/144254> All reviewed patches have been landed. Closing bug. |