Summary: | Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, hausmann, jturcotte, kadam, ossy, zarvai, zeno | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2013-02-25 16:38:50 PST
Created attachment 190155 [details]
Patch
Committed r143988: <http://trac.webkit.org/changeset/143988> (In reply to comment #2) > Committed r143988: <http://trac.webkit.org/changeset/143988> It broke the !ENABLE(NETSCAPE_PLUGIN_API) builds, for example Qt Mountain Lion: /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:2655:136: error: use of undeclared identifier 'plugin' m_uiClient.unavailablePluginButtonClicked(this, pluginUnavailabilityReason, mimeType, pluginBundleIdentifier, pluginBundleVersion, plugin.info.name, pluginURLString, pluginspageAttributeURLString, frameURLString, pageURLString); CC Qt folks to fix the broken build. (In reply to comment #3) > (In reply to comment #2) > > Committed r143988: <http://trac.webkit.org/changeset/143988> > > It broke the !ENABLE(NETSCAPE_PLUGIN_API) builds, for example Qt Mountain Lion: > > /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:2655:136: error: use of undeclared identifier 'plugin' > m_uiClient.unavailablePluginButtonClicked(this, pluginUnavailabilityReason, mimeType, pluginBundleIdentifier, pluginBundleVersion, plugin.info.name, pluginURLString, pluginspageAttributeURLString, frameURLString, pageURLString); > > CC Qt folks to fix the broken build. Thanks for spotting :). Fixed in http://trac.webkit.org/changeset/144015 |