Bug 110821

Summary: Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, hausmann, jturcotte, kadam, ossy, zarvai, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bdakin: review+

Anders Carlsson
Reported 2013-02-25 16:38:50 PST
Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
Attachments
Patch (33.45 KB, patch)
2013-02-25 16:45 PST, Anders Carlsson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-02-25 16:45:54 PST
Created attachment 190155 [details] Patch
Anders Carlsson
Comment 2 2013-02-25 17:08:51 PST
Committed r143988: <http://trac.webkit.org/changeset/143988>
Csaba Osztrogonác
Comment 3 2013-02-25 22:02:59 PST
(In reply to comment #2) > Committed r143988: <http://trac.webkit.org/changeset/143988> It broke the !ENABLE(NETSCAPE_PLUGIN_API) builds, for example Qt Mountain Lion: /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:2655:136: error: use of undeclared identifier 'plugin' m_uiClient.unavailablePluginButtonClicked(this, pluginUnavailabilityReason, mimeType, pluginBundleIdentifier, pluginBundleVersion, plugin.info.name, pluginURLString, pluginspageAttributeURLString, frameURLString, pageURLString); CC Qt folks to fix the broken build.
Simon Hausmann
Comment 4 2013-02-26 00:39:06 PST
(In reply to comment #3) > (In reply to comment #2) > > Committed r143988: <http://trac.webkit.org/changeset/143988> > > It broke the !ENABLE(NETSCAPE_PLUGIN_API) builds, for example Qt Mountain Lion: > > /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:2655:136: error: use of undeclared identifier 'plugin' > m_uiClient.unavailablePluginButtonClicked(this, pluginUnavailabilityReason, mimeType, pluginBundleIdentifier, pluginBundleVersion, plugin.info.name, pluginURLString, pluginspageAttributeURLString, frameURLString, pageURLString); > > CC Qt folks to fix the broken build. Thanks for spotting :). Fixed in http://trac.webkit.org/changeset/144015
Note You need to log in before you can comment on or make changes to this bug.