Bug 110821 - Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
Summary: Add a new unavailablePluginButtonClicked callback that takes a WKDictionary o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-25 16:38 PST by Anders Carlsson
Modified: 2013-02-26 00:39 PST (History)
7 users (show)

See Also:

Attachments
Patch (33.45 KB, patch)
2013-02-25 16:45 PST, Anders Carlsson 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-02-25 16:38:50 PST 
Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
Comment 1 Anders Carlsson 2013-02-25 16:45:54 PST 
Created attachment 190155 [details]
Patch
Comment 2 Anders Carlsson 2013-02-25 17:08:51 PST 
Committed r143988: <http://trac.webkit.org/changeset/143988>
Comment 3 Csaba Osztrogonác 2013-02-25 22:02:59 PST 
(In reply to comment #2)
> Committed r143988: <http://trac.webkit.org/changeset/143988>

It broke the !ENABLE(NETSCAPE_PLUGIN_API) builds, for example Qt Mountain Lion:

/Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:2655:136: error: use of undeclared identifier 'plugin'
    m_uiClient.unavailablePluginButtonClicked(this, pluginUnavailabilityReason, mimeType, pluginBundleIdentifier, pluginBundleVersion, plugin.info.name, pluginURLString, pluginspageAttributeURLString, frameURLString, pageURLString);

CC Qt folks to fix the broken build.
Comment 4 Simon Hausmann 2013-02-26 00:39:06 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > Committed r143988: <http://trac.webkit.org/changeset/143988>
> 
> It broke the !ENABLE(NETSCAPE_PLUGIN_API) builds, for example Qt Mountain Lion:
> 
> /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:2655:136: error: use of undeclared identifier 'plugin'
>     m_uiClient.unavailablePluginButtonClicked(this, pluginUnavailabilityReason, mimeType, pluginBundleIdentifier, pluginBundleVersion, plugin.info.name, pluginURLString, pluginspageAttributeURLString, frameURLString, pageURLString);
> 
> CC Qt folks to fix the broken build.

Thanks for spotting :). Fixed in http://trac.webkit.org/changeset/144015