Bug 110816

Summary: getPropertyValue for -webkit-marquee returns null, should compute the shorthand value
Product: WebKit Reporter: Uday Kiran <udaykiran4u>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, esprehn+autocc, macpherson, menard, ojan.autocc, udaykiran4u, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103244    
Attachments:
Description Flags
Patch
none
Patch none

Uday Kiran
Reported 2013-02-25 16:00:47 PST
style.getPropertyValue("-webkit-marquee") shorthand returns null
Attachments
Patch (7.43 KB, patch)
2013-02-25 16:16 PST, Uday Kiran 		no flags
DetailsFormatted DiffDiff
Patch (7.68 KB, patch)
2013-02-26 10:05 PST, Uday Kiran 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Uday Kiran
Comment 1 2013-02-25 16:16:56 PST
Created attachment 190151 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2013-02-25 22:01:55 PST
Comment on attachment 190151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190151&action=review > LayoutTests/fast/css/getPropertyValue-webkit-marquee.html:3 > +<head> It is a good idea to use proper tag indentation inside the <html> to enhance readability. Even one space will work, like in getPropertyValue-border.html > LayoutTests/fast/css/getPropertyValue-webkit-marquee.html:36 > +description("<a href=\"https://bugs.webkit.org/show_bug.cgi?id=110816\">Bug 110816: getPropertyValue for -webkit-marquee returns null, should compute the shorthand value</a>"); The code inside <script> should also be indented relative to the <script> tag. > LayoutTests/fast/css/getPropertyValue-webkit-marquee.html:38 > +function testWebkitMarquee(id) { This does not actually test the property but returns its value. I believe "webkitMarqueeValue" will work as a new name.
Uday Kiran
Comment 3 2013-02-26 10:05:39 PST
Created attachment 190319 [details] Patch Fixed indentation.
Alexander Pavlov (apavlov)
Comment 4 2013-02-26 21:56:43 PST
Comment on attachment 190319 [details] Patch r=me
WebKit Review Bot
Comment 5 2013-02-26 22:08:25 PST
Comment on attachment 190319 [details] Patch Clearing flags on attachment: 190319 Committed r144144: <http://trac.webkit.org/changeset/144144>
WebKit Review Bot
Comment 6 2013-02-26 22:08:29 PST
All reviewed patches have been landed. Closing bug.
Uday Kiran
Comment 7 2013-02-27 15:21:03 PST
Thanks for review and cq+.
Note You need to log in before you can comment on or make changes to this bug.