Bug 110812

Summary:

Implement channel up-mixing and down-mixing rules

Product:

WebKit

Reporter:

Chris Rogers <crogers>

Component:

New Bugs

Assignee:

Chris Rogers <crogers>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric.carlson, esprehn+autocc, feature-media-reviews, jer.noble, kbr, ojan.autocc, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kbr: review+

Description Chris Rogers 2013-02-25 15:16:24 PST

Implement channel up-mixing and down-mixing rules

Comment 1 Chris Rogers 2013-02-25 15:25:31 PST

Created attachment 190140 [details]
Patch

Comment 2 Kenneth Russell 2013-02-26 12:48:40 PST

Comment on attachment 190140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190140&action=review

Looks good. Thanks for the explanation offline about the algorithm and the layout test. One comment.

> Source/WebCore/platform/audio/AudioBus.cpp:385
> +        vadd(sourceC, 1, destination, 1, destination, 1, length());

This is basically exactly the same code as in speakersCopyFrom. Could you refactor it into a separate method to share the code?

Comment 3 Chris Rogers 2013-02-27 13:49:10 PST

Committed r144235: <http://trac.webkit.org/changeset/144235>