Bug 110787

Summary: [BlackBerry] Use APIEntryShim when making JS call
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch none

Yong Li
Reported 2013-02-25 13:03:26 PST
PR 301451.
Attachments
the patch (1.57 KB, patch)
2013-02-25 13:10 PST, Yong Li 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2013-02-25 13:10:04 PST
Created attachment 190112 [details] the patch .
Rob Buis
Comment 2 2013-02-25 13:18:08 PST
Comment on attachment 190112 [details] the patch LGTM.
WebKit Review Bot
Comment 3 2013-02-25 18:51:45 PST
Comment on attachment 190112 [details] the patch Rejecting attachment 190112 [details] from commit-queue. yong.li.webkit@outlook.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Yong Li
Comment 4 2013-02-26 04:31:55 PST
Comment on attachment 190112 [details] the patch try again
WebKit Review Bot
Comment 5 2013-02-26 04:57:13 PST
Comment on attachment 190112 [details] the patch Rejecting attachment 190112 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190112, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://webkit-commit-queue.appspot.com/results/16771101
WebKit Review Bot
Comment 6 2013-02-26 10:06:34 PST
Comment on attachment 190112 [details] the patch Clearing flags on attachment: 190112 Committed r144069: <http://trac.webkit.org/changeset/144069>
WebKit Review Bot
Comment 7 2013-02-26 10:06:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.