Bug 110787 - [BlackBerry] Use APIEntryShim when making JS call
Summary: [BlackBerry] Use APIEntryShim when making JS call
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-25 13:03 PST by Yong Li
Modified: 2013-02-26 10:06 PST (History)
1 user (show)

See Also:

Attachments
the patch (1.57 KB, patch)
2013-02-25 13:10 PST, Yong Li 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2013-02-25 13:03:26 PST 
PR 301451.
Comment 1 Yong Li 2013-02-25 13:10:04 PST 
Created attachment 190112 [details]
the patch

.
Comment 2 Rob Buis 2013-02-25 13:18:08 PST 
Comment on attachment 190112 [details]
the patch

LGTM.
Comment 3 WebKit Review Bot 2013-02-25 18:51:45 PST 
Comment on attachment 190112 [details]
the patch

Rejecting attachment 190112 [details] from commit-queue.

yong.li.webkit@outlook.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 Yong Li 2013-02-26 04:31:55 PST 
Comment on attachment 190112 [details]
the patch

try again
Comment 5 WebKit Review Bot 2013-02-26 04:57:13 PST 
Comment on attachment 190112 [details]
the patch

Rejecting attachment 190112 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190112, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:

fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2

Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Full output: http://webkit-commit-queue.appspot.com/results/16771101
Comment 6 WebKit Review Bot 2013-02-26 10:06:34 PST 
Comment on attachment 190112 [details]
the patch

Clearing flags on attachment: 190112

Committed r144069: <http://trac.webkit.org/changeset/144069>
Comment 7 WebKit Review Bot 2013-02-26 10:06:36 PST 
All reviewed patches have been landed.  Closing bug.